[U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic

[U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic

[Bin Meng]

Hi Simon, Anatolij,

At present CONFIG_DISPLAY is set to y by default when driver model is
on. This causes the following building error on microblaze-generic.

  drivers/built-in.o: In function 'display_read_timing':
  drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'

I think we should make CONFIG_DISPLAY 'default n' and update whatever
boards who want DM video support to explicitly turn in on in its board
defconfig files. This will fix microblaze-generic build error too.

Regards,
Bin

[U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic

[Tom Rini]

On Mon, Jan 25, 2016 at 10:08:20PM +0800, Bin Meng wrote:

> Hi Simon, Anatolij,
> 
> At present CONFIG_DISPLAY is set to y by default when driver model is
> on. This causes the following building error on microblaze-generic.
> 
>   drivers/built-in.o: In function 'display_read_timing':
>   drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'
> 
> I think we should make CONFIG_DISPLAY 'default n' and update whatever
> boards who want DM video support to explicitly turn in on in its board
> defconfig files. This will fix microblaze-generic build error too.

This is a Kconfig thinko, yes, as we're enabling stuff we don't need
everywhere.  I talked with Simon about this the other day as it's
causing a slight bloat everywhere too.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/1a931a75/attachment.sig>

[U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic

[Anatolij Gustschin]

Hi Bin,

> Hi Simon, Anatolij,
> 
> At present CONFIG_DISPLAY is set to y by default when driver model is
> on. This causes the following building error on microblaze-generic.
> 
>   drivers/built-in.o: In function 'display_read_timing':
>   drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'
>
> I think we should make CONFIG_DISPLAY 'default n' and update whatever
> boards who want DM video support to explicitly turn in on in its board
> defconfig files. This will fix microblaze-generic build error too.

CONFIG_DISPLAY depends on CONFIG_I2C_EDID, this should be considered
in Kconfig, too.

--
Anatolij