* [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic
@ 2016-01-25 14:08 Bin Meng
2016-01-25 15:17 ` Tom Rini
2016-01-25 15:33 ` Anatolij Gustschin
0 siblings, 2 replies; 3+ messages in thread
From: Bin Meng @ 2016-01-25 14:08 UTC (permalink / raw)
To: u-boot
Hi Simon, Anatolij,
At present CONFIG_DISPLAY is set to y by default when driver model is
on. This causes the following building error on microblaze-generic.
drivers/built-in.o: In function 'display_read_timing':
drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'
I think we should make CONFIG_DISPLAY 'default n' and update whatever
boards who want DM video support to explicitly turn in on in its board
defconfig files. This will fix microblaze-generic build error too.
Regards,
Bin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic
2016-01-25 14:08 [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic Bin Meng
@ 2016-01-25 15:17 ` Tom Rini
2016-01-25 15:33 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-01-25 15:17 UTC (permalink / raw)
To: u-boot
On Mon, Jan 25, 2016 at 10:08:20PM +0800, Bin Meng wrote:
> Hi Simon, Anatolij,
>
> At present CONFIG_DISPLAY is set to y by default when driver model is
> on. This causes the following building error on microblaze-generic.
>
> drivers/built-in.o: In function 'display_read_timing':
> drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'
>
> I think we should make CONFIG_DISPLAY 'default n' and update whatever
> boards who want DM video support to explicitly turn in on in its board
> defconfig files. This will fix microblaze-generic build error too.
This is a Kconfig thinko, yes, as we're enabling stuff we don't need
everywhere. I talked with Simon about this the other day as it's
causing a slight bloat everywhere too.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/1a931a75/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic
2016-01-25 14:08 [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic Bin Meng
2016-01-25 15:17 ` Tom Rini
@ 2016-01-25 15:33 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2016-01-25 15:33 UTC (permalink / raw)
To: u-boot
Hi Bin,
> Hi Simon, Anatolij,
>
> At present CONFIG_DISPLAY is set to y by default when driver model is
> on. This causes the following building error on microblaze-generic.
>
> drivers/built-in.o: In function 'display_read_timing':
> drivers/video/display-uclass.c:45: undefined reference to 'edid_get_timing'
>
> I think we should make CONFIG_DISPLAY 'default n' and update whatever
> boards who want DM video support to explicitly turn in on in its board
> defconfig files. This will fix microblaze-generic build error too.
CONFIG_DISPLAY depends on CONFIG_I2C_EDID, this should be considered
in Kconfig, too.
--
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 14:08 [U-Boot] CONFIG_DISPLAY causes build error on microblaze-generic Bin Meng
2016-01-25 15:17 ` Tom Rini
2016-01-25 15:33 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox