From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH REPOST] checkpatch: ignore request to use ether_addr_copy()
Date: Mon, 25 Jan 2016 21:43:30 +0100 [thread overview]
Message-ID: <201601252143.31008.marex@denx.de> (raw)
In-Reply-To: <1453740480-1558-1-git-send-email-swarren@wwwdotorg.org>
On Monday, January 25, 2016 at 05:48:00 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The Linux kernel, from which checkpatch originates, contains function
> ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns
> that it should be used in preference to memcpy() where appropriate.
> U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to issue
> this warning.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
+CC Tom, Simon
> ---
> .checkpatch.conf | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.checkpatch.conf b/.checkpatch.conf
> index 35167e12015b..d1d32fac9db5 100644
> --- a/.checkpatch.conf
> +++ b/.checkpatch.conf
> @@ -21,3 +21,7 @@
>
> # Ignore networking block comment style
> --ignore NETWORKING_BLOCK_COMMENT_STYLE
> +
> +# Ignore "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> +# addresses are __aligned(2)".
> +--ignore PREFER_ETHER_ADDR_COPY
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-25 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 16:48 [U-Boot] [PATCH REPOST] checkpatch: ignore request to use ether_addr_copy() Stephen Warren
2016-01-25 20:43 ` Marek Vasut [this message]
2016-01-25 21:34 ` Stephen Warren
2016-01-25 21:38 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601252143.31008.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox