public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] spi: omap3: Convert to DM
Date: Mon, 25 Jan 2016 21:45:47 -0500	[thread overview]
Message-ID: <20160126024547.GV3359@bill-the-cat> (raw)
In-Reply-To: <20160126015541.GB13773@linux-7smt.suse>

On Tue, Jan 26, 2016 at 09:55:43AM +0800, Peng Fan wrote:
> Hi Simon,
> 
> On Mon, Jan 25, 2016 at 06:11:24PM -0700, Simon Glass wrote:
> >+Hans
> >
> >Hi Tom,
> >
> >On 21 January 2016 at 05:24, Tom Rini <trini@konsulko.com> wrote:
> >> On Wed, Jan 20, 2016 at 07:46:15PM -0700, Simon Glass wrote:
> >>> +Mugunthan, Tom
> >>>
> >>> On 17 January 2016 at 03:56, Christophe Ricard
> >>> <christophe.ricard@gmail.com> wrote:
> >>> > Convert omap3_spi driver to DM and keep compatibility with previous
> >>> > mode.
> >>> >
> >>> > Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
> >>> > ---
> >>> >
> >>> >  drivers/spi/Kconfig     |   6 +
> >>> >  drivers/spi/omap3_spi.c | 439 ++++++++++++++++++++++++++++++++++++++++++------
> >>> >  drivers/spi/omap3_spi.h |  14 +-
> >>> >  3 files changed, 402 insertions(+), 57 deletions(-)
> >>>
> >>> This is a pretty painful conversion, with lots of #ifdefs. I think it
> >>> would be possible to use a common pointer type and reduce this.
> >>>
> >>> But perhaps it does not matter - how long must we be in the state of
> >>> supporting legacy SPI? Can we convert all TI boards to driver model?
> >>
> >> We _really_ need some way to support more than one board per binary
> >> before we can move everything to DM only.
> >>
> >> I think we can kind of do this today if we stick to using platform data
> >> for everything that's board-specific rather than SoC-defined.  What we
> >> talked about at ELCE was auto-generating the pdata from the device tree,
> >> I think.
> >
> >We discussed this on IRC but since that doesn't exist as far as the
> >mailing list is concerned...
> >
> >The current plan is:
> >
> >- Adjust build system to optionally build a u-boot.img in FIT format
> >that includes the U-Boot binary and >1 device tree files
> >- Adjust SPL to load this
> >- Add a way for SPL to determine which device tree to select (by
> >calling a board-specific function)
> >- Have SPL pass this selected device tree to U-Boot when it starts
> 
> Can dtb be sperated from the final u-boot.img, if using SPL?
> I mean let SPL load the u-boot.img and the dtb to correct DRAM address.
> And the dtb is shared with linux kernel.

This sounds similar, but different.  The problem I'm asking to be solved
is that at the starting point, there are no DTBs on the hardware.  But
we can in software easily and reliable tell which of say 3 boards we are
on.  At that point, we need to make sure that both SPL and then U-Boot
know which board they are on.  And if in U-Boot we use the DT to pass in
all data, it has to be correct.  It sounds to me like you're describing
the case where the HW has the dtb stored at a known location and you
just don't need it embedded within SPL/U-Boot.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/740f7cc4/attachment.sig>

  parent reply	other threads:[~2016-01-26  2:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 10:56 [U-Boot] [PATCH 0/4] Convert omap3-spi driver to Driver Model Christophe Ricard
2016-01-17 10:56 ` [U-Boot] [PATCH 1/4] spi: omap3: Remove unused variable irqstatus in omap3_spi_txrx Christophe Ricard
2016-01-21  2:46   ` Simon Glass
2016-02-10 19:19     ` Jagan Teki
2016-01-17 10:56 ` [U-Boot] [PATCH 2/4] spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN Christophe Ricard
2016-01-21  2:46   ` Simon Glass
2016-02-10 19:19     ` Jagan Teki
2016-01-17 10:56 ` [U-Boot] [PATCH 3/4] spi: omap3: Convert to DM Christophe Ricard
2016-01-21  2:46   ` Simon Glass
2016-01-21 12:24     ` Tom Rini
2016-01-26  1:11       ` Simon Glass
2016-01-26  1:55         ` Peng Fan
2016-01-26  2:18           ` Simon Glass
2016-01-26  2:45           ` Tom Rini [this message]
2016-01-26  2:58             ` Peng Fan
2016-01-26 15:12               ` Tom Rini
2016-01-27  2:46                 ` Peng Fan
2016-02-06 22:27           ` Christophe Ricard
2016-02-08 17:40             ` Tom Rini
2016-02-08 17:56               ` Jagan Teki
2016-02-10 19:16                 ` Jagan Teki
2016-02-10 21:00                   ` Christophe Ricard
2016-02-10 23:44                     ` Tom Rini
2016-02-11 15:01                     ` Jagan Teki
2016-02-11 16:44                       ` Jagan Teki
2016-01-17 10:56 ` [U-Boot] [PATCH 4/4] spi: omap3: Convert fully to DM_SPI Christophe Ricard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126024547.GV3359@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox