public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env_mmc: support overriding mmc dev from board code
Date: Tue, 26 Jan 2016 10:52:39 +0100	[thread overview]
Message-ID: <20160126095239.GA1948@archie.tuxnet.lan> (raw)
In-Reply-To: <20160126025341.GA15145@linux-7smt.suse>

On Tue, Jan 26, 2016 at 10:53:58AM +0800, Peng Fan wrote:
> Yeah. The patch I wrote include fix write_env, and a function prototype in
> header file.
> 
> If the current patch already applied, I can write a follow up patch.
> 
> Thanks,
> Peng.
> 

Hi Peng,

sorry, I did not know there was already a similar patch.

However, now when looking over your patch, it tries to fix read_env and
write_env, which is not necessary, because the device number is stored
in struct mmc.

What's missing though is the function prototype in the header.

Tom, should I send a v2 of the patch or a follow-up? Or do you want to
fix this up, Peng?

Thanks.
Clemens

  reply	other threads:[~2016-01-26  9:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 14:43 [U-Boot] [PATCH] env_mmc: support overriding mmc dev from board code Clemens Gruber
2016-01-20 16:57 ` Stephen Warren
2016-01-21 19:10 ` Tom Rini
2016-01-25 21:28 ` [U-Boot] " Tom Rini
2016-01-26  1:42   ` Peng Fan
2016-01-26  2:13     ` Tom Rini
2016-01-26  2:53       ` Peng Fan
2016-01-26  9:52         ` Clemens Gruber [this message]
2016-01-26 15:00           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126095239.GA1948@archie.tuxnet.lan \
    --to=clemens.gruber@pqgruber.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox