[U-Boot] [PATCH v2 1/2] board:freescale:common: Move device-tree fixup framework to common file

Sriram Dash
2016-02-26T16:07:31Z

Please find my reply inline

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: Thursday, February 25, 2016 11:28 PM
To: Sriram Dash <sriram.dash@nxp.com>; u-boot at lists.denx.de
Cc: york sun <york.sun@nxp.com>; Ramneek Mehresh <ramneek.mehresh@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: Re: [PATCH v2 1/2] board:freescale:common: Move device-tree fixup framework to common file

On 02/24/2016 05:44 AM, Sriram Dash wrote:
> Move usb device-tree fixup framework from ehci-fsl.c to common place
> so that it can be used by other drivers as well (xhci-fsl.c).
> Also, call fdt_usb_get_node_type() from fdt_fixup_usb_mode_phy_type()
> to avoid code duplication.
>
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@nxp.com>
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>

Is this just moving the code ? If so, please resubmit and use git format-patch -M -C to generate the patches for the submission. It makes it much easier to detect moved files.

[Sriram] No, this patch is performing two actions:

1. Move usb device-tree fixup framework from ehci-fsl.c to common place
so that it can be used by other drivers as well (xhci-fsl.c).

2. Call fdt_usb_get_node_type() from fdt_fixup_usb_mode_phy_type()
to avoid code duplication.