From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch resend] nand: mxs: fix error handling for mxs_nand_init
Date: Wed, 27 Jan 2016 04:10:20 +0100 [thread overview]
Message-ID: <201601270410.20459.marex@denx.de> (raw)
In-Reply-To: <1453862282-10019-1-git-send-email-van.freenix@gmail.com>
On Wednesday, January 27, 2016 at 03:38:02 AM, Peng Fan wrote:
> Fix error handling for mxs_nand_init.
>
> The original error handling is wrong for err2 and err1.
> Should first free desc[x], then free desc.
>
> This patch also correctly handle err3, should use
> MXS_DMA_CHANNEL_AHB_APBH_GPMI0 as the check point.
>
> Cc: Stefano Babic <sbabic@denx.de>
> CC: Fabio Estevam <Fabio.Estevam@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
It looks fine,
Reviewed-by: Marek Vasut <marex@denx.de>
Why the resend btw ?
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-01-27 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 2:38 [U-Boot] [patch resend] nand: mxs: fix error handling for mxs_nand_init Peng Fan
2016-01-27 3:10 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601270410.20459.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox