[U-Boot] [PATCH 3/3] mips: ath79: Move SYS_SOC and SYS_VENDOR to board Kconfig

Marek Vasut
2016-01-29T08:50:05Z

On Friday, January 29, 2016 at 09:46:24 AM, Wills Wang wrote:
> On Thursday, January 28, 2016 10:53 PM, Marek Vasut wrote:
> > On Thursday, January 28, 2016 at 03:43:58 PM, Wills Wang wrote:
> >> On Thursday, January 28, 2016 09:44 PM, Marek Vasut wrote:
> >>> On Thursday, January 28, 2016 at 02:31:11 PM, Wills Wang wrote:
> >>>> On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
> >>>>> In order to support boards with ath79 from different vendors and
> >>>>> thus located under /board/$VENDOR/ , we need to define SYS_VENDOR
> >>>>> and SYS_SOC in the board-level Kconfig. Move these two variables
> >>>>> into board-level Kconfig for both ap121 and ap143 boards.
> >>>>>
> >>>>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>>>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> >>>>> Cc: Wills Wang <wills.wang@live.com>
> >>>>> ---
> >>>>>
> >>>>> arch/mips/mach-ath79/Kconfig | 6 ------
> >>>>> board/ath79/ap121/Kconfig | 6 ++++++
> >>>>> board/ath79/ap143/Kconfig | 6 ++++++
> >>>>> 3 files changed, 12 insertions(+), 6 deletions(-)
> >>>>>
> >>>>> diff --git a/arch/mips/mach-ath79/Kconfig
> >>>>> b/arch/mips/mach-ath79/Kconfig index 95f7de9..8f07a77 100644
> >>>>> --- a/arch/mips/mach-ath79/Kconfig
> >>>>> +++ b/arch/mips/mach-ath79/Kconfig
> >>>>> @@ -1,12 +1,6 @@
> >>>>>
> >>>>> menu "QCA/Athroes 7xxx/9xxx platforms"
> >>>>>
> >>>>> depends on ARCH_ATH79
> >>>>>
> >>>>> -config SYS_VENDOR
> >>>>> - default "ath79"
> >>>>> -
> >>>>> -config SYS_SOC
> >>>>> - default "ath79"
> >>>>> -
> >>>>>
> >>>>> config SOC_AR933X
> >>>>>
> >>>>> bool
> >>>>> select SUPPORTS_BIG_ENDIAN
> >>>>>
> >>>>> diff --git a/board/ath79/ap121/Kconfig b/board/ath79/ap121/Kconfig
> >>>>> index ec72914..a4e5690 100644
> >>>>> --- a/board/ath79/ap121/Kconfig
> >>>>> +++ b/board/ath79/ap121/Kconfig
> >>>>> @@ -1,5 +1,11 @@
> >>>>>
> >>>>> if BOARD_AP121
> >>>>>
> >>>>> +config SYS_VENDOR
> >>>>> + default "ath79"
> >>>>> +
> >>>>> +config SYS_SOC
> >>>>> + default "ath79"
> >>>>> +
> >>>>>
> >>>>> config SYS_BOARD
> >>>>>
> >>>>> default "ap121"
> >>>>>
> >>>>> diff --git a/board/ath79/ap143/Kconfig b/board/ath79/ap143/Kconfig
> >>>>> index 118b9b5..2e54fa7 100644
> >>>>> --- a/board/ath79/ap143/Kconfig
> >>>>> +++ b/board/ath79/ap143/Kconfig
> >>>>> @@ -1,5 +1,11 @@
> >>>>>
> >>>>> if BOARD_AP143
> >>>>>
> >>>>> +config SYS_VENDOR
> >>>>> + default "ath79"
> >>>>> +
> >>>>> +config SYS_SOC
> >>>>> + default "ath79"
> >>>>> +
> >>>>>
> >>>>> config SYS_BOARD
> >>>>>
> >>>>> default "ap143"
> >>>>
> >>>> I plan to place ap121 and ap143 into board/qca, and then
> >>>> move these into board directory.
> >>>
> >>> That's fine, but keep this patch or something along those lines, since
> >>> I want to create board/arduino/yun/ soon after your stuff is accepted.
> >>>
> >>> btw. I got both EHCI and ethernet operational, but I am still
> >>> struggling with booting the board from the SPI NOR. I think there's
> >>> something broken in start.S or lowlevel_init.S . Which board do you
> >>> use for your development and testing ?
> >>
> >> My private board was made by myself, it originate from AP121, and
> >> it's circuit is compatible with AP121.
> >
> > How do you program your board ? Do you have EJTAG?
> >
> > What SPI NOR do you use?
>
> My flash chip is W25Q64FV.
> I place a chip socket on board, flash chip can be plugged in or out easily.

I see, OK.

Just out of sheer curiosity, are you doing the ath79 support as a hobby thing
or are you putting out an actual product ?

Also, you might want to join the u-boot IRC, it's easier to discuss things in
real time.

Best regards,
Marek Vasut