public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: use common instructions applicable to armv7m & other arm archs
Date: Fri, 29 Jan 2016 18:15:46 +0100	[thread overview]
Message-ID: <20160129181546.5e427a86@lilith> (raw)
In-Reply-To: <1453171978-30715-1-git-send-email-vikas.manocha@st.com>

Hello Vikas,

On Mon, 18 Jan 2016 18:52:57 -0800, Vikas Manocha
<vikas.manocha@st.com> wrote:
> BIC instruction to clear the SP is not allowed in armv7m & is deprecated
> in ARMv6T2 & above. This patch cleans the code by using instructions allowed
> for armv7m as well as other Arm archs.

I am not against this patch, which has merits on its own; but the
commit message above raises a couple of questions.

1. It seems to imply that in the current arch/arm/lib/crt0.S, BIC is
   incorrectly being used on sp. However, it is *not*; it is used on r3,
   precisely because it cannot be used directly on sp, as the comment
   before the bic instruction clearly states. Why does the commit
   message raise this non-issue?

2. I could not find any information on BIC being deprecated in
   Architecture Reference Manuals of either ArmV7 (section "Deprecated
   Features in ARMv7-M", or ARMv6-M (section "Deprecated and Obsolete
   Features"). Where does this information come from?

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2016-01-29 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  2:52 [U-Boot] [PATCH] arm: use common instructions applicable to armv7m & other arm archs Vikas Manocha
2016-01-19  3:11 ` Simon Glass
2016-01-29 17:15 ` Albert ARIBAUD [this message]
2016-01-29 23:36   ` Vikas MANOCHA
2016-01-31 15:00     ` Albert ARIBAUD
2016-02-01 23:48       ` Vikas MANOCHA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129181546.5e427a86@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox