From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] patman: fix series-notes handling for buildman
Date: Sun, 31 Jan 2016 17:51:51 +0100 [thread overview]
Message-ID: <20160131175151.3a228bc8@lilith> (raw)
In-Reply-To: <CAPnjgZ2WnZJFVy3jc7hgqxaKdq2MZf_NZuKrDpSx=D6BWbymsQ@mail.gmail.com>
Hello Simon,
On Thu, 19 Nov 2015 20:29:11 -0700, Simon Glass <sjg@chromium.org>
wrote:
> Hi Albert,
>
> On 13 November 2015 at 19:35, Simon Glass <sjg@chromium.org> wrote:
> > On 9 November 2015 at 14:36, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
> >> Hello Simon,
> >>
> >> On Mon, 9 Nov 2015 12:24:55 -0800, Simon Glass <sjg@chromium.org> wrote:
> >>> On 9 November 2015 at 06:19, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
> >>> > A patman series with a 'Series-notes' section causes
> >>> > buildman to crash with:
> >>> >
> >>> > self.series.notes += self.section
> >>> > TypeError: cannot concatenate 'str' and 'list' objects
> >>> >
> >>> > Fix by initializing series.notes as a one-element array
> >>> > rathen than a scalar.
> >>> >
> >>> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >>> > ---
> >>> >
> >>> > tools/patman/series.py | 2 +-
> >>> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> Acked-by: Simon Glass <sjg@chromium.org>
> >>
> >> Note: just spotted a typo, 'rathen' instead of 'rather'. If this patch
> >> gets applied, please fix that on-the-fly.
> >>
> >> Amicalement,
> >> --
> >> Albert.
> >
> > Fixed typo and
> >
> > Applied to u-boot-dm, thanks!
>
> Hmm, actually I've had to drop this as it breaks 'Series-version'.
> That currently does not expect a list.
Hmm, I can't reproduce this here. How do you trigger the Series-version
break?
> I wonder if Series-notes needs a special case, instead?
>
> Regards,
> Simon
Amicalement,
--
Albert.
next prev parent reply other threads:[~2016-01-31 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 14:19 [U-Boot] [PATCH] patman: fix series-notes handling for buildman Albert ARIBAUD
2015-11-09 20:24 ` Simon Glass
2015-11-09 21:36 ` Albert ARIBAUD
2015-11-14 2:35 ` Simon Glass
2015-11-20 3:29 ` Simon Glass
2016-01-31 16:51 ` Albert ARIBAUD [this message]
2016-02-02 0:05 ` Simon Glass
2016-02-02 9:25 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131175151.3a228bc8@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox