From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 31 Jan 2016 17:51:51 +0100 Subject: [U-Boot] [PATCH] patman: fix series-notes handling for buildman In-Reply-To: References: <1447078784-32060-1-git-send-email-albert.u.boot@aribaud.net> <20151109223657.2954f8ac@lilith> Message-ID: <20160131175151.3a228bc8@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On Thu, 19 Nov 2015 20:29:11 -0700, Simon Glass wrote: > Hi Albert, > > On 13 November 2015 at 19:35, Simon Glass wrote: > > On 9 November 2015 at 14:36, Albert ARIBAUD wrote: > >> Hello Simon, > >> > >> On Mon, 9 Nov 2015 12:24:55 -0800, Simon Glass wrote: > >>> On 9 November 2015 at 06:19, Albert ARIBAUD wrote: > >>> > A patman series with a 'Series-notes' section causes > >>> > buildman to crash with: > >>> > > >>> > self.series.notes += self.section > >>> > TypeError: cannot concatenate 'str' and 'list' objects > >>> > > >>> > Fix by initializing series.notes as a one-element array > >>> > rathen than a scalar. > >>> > > >>> > Signed-off-by: Albert ARIBAUD > >>> > --- > >>> > > >>> > tools/patman/series.py | 2 +- > >>> > 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> Acked-by: Simon Glass > >> > >> Note: just spotted a typo, 'rathen' instead of 'rather'. If this patch > >> gets applied, please fix that on-the-fly. > >> > >> Amicalement, > >> -- > >> Albert. > > > > Fixed typo and > > > > Applied to u-boot-dm, thanks! > > Hmm, actually I've had to drop this as it breaks 'Series-version'. > That currently does not expect a list. Hmm, I can't reproduce this here. How do you trigger the Series-version break? > I wonder if Series-notes needs a special case, instead? > > Regards, > Simon Amicalement, -- Albert.