[U-Boot] [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video drivers to driver model

Tom Warren
2016-02-16T16:23:52Z

Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Tuesday, February 16, 2016 9:03 AM
> To: Tom Warren <TWarren@nvidia.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>; U-Boot Mailing List <u-
> boot at lists.denx.de>; Marcel Ziswiler <marcel.ziswiler@toradex.com>; Stephen
> Warren <swarren@nvidia.com>; Pantelis Antoniou <panto@antoniou-
> consulting.com>; Marek Vasut <marek.vasut@gmail.com>; Pavel Herrmann
> <morpheus.ibis@gmail.com>; Anatolij Gustschin <agust@denx.de>
> Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and tegra124 video
> drivers to driver model
>
> Hi Tom,
>
> On 16 February 2016 at 08:47, Tom Warren <TWarren@nvidia.com> wrote:
> >
> > Simon
> >
> > > -----Original Message-----
> > > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon
> > > Glass
> > > Sent: Sunday, February 14, 2016 6:19 PM
> > > To: Stephen Warren <swarren@wwwdotorg.org>
> > > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Marcel Ziswiler
> > > <marcel.ziswiler@toradex.com>; Tom Warren <TWarren@nvidia.com>;
> > > Stephen Warren <swarren@nvidia.com>; Pantelis Antoniou
> > > <panto@antoniou- consulting.com>; Marek Vasut
> > > <marek.vasut@gmail.com>; Pavel Herrmann <morpheus.ibis@gmail.com>;
> > > Anatolij Gustschin <agust@denx.de>
> > > Subject: Re: [PATCH v2 00/23] dm: tegra: Convert tegra20 and
> > > tegra124 video drivers to driver model
> > >
> > > Hi,
> > >
> > > On 1 February 2016 at 17:00, Stephen Warren <swarren@wwwdotorg.org>
> > > wrote:
> > > >
> > > > On 01/30/2016 04:37 PM, Simon Glass wrote:
> > > >>
> > > >> This series moves these two drivers over to use driver model for video.
> > > >>
> > > >> This involves the following steps:
> > > >> - Sync up some device tree files with Linux
> > > >> - Implement a proper PWM driver
> > > >> - Clean up and unify the driver code
> > > >> - Modify the existing drivers to work with driver model
> > > >>
> > > >> The tegra20 display driver uses device tree bindings invented in
> > > >> 2011 before Linux had this or anyone was able to agree a
> > > >> standard. It seems possible to move it to the new bindings (like
> > > >> tegra124) except for the issue of time delays between stages. It
> > > >> isn't clear how this should work, and Linux implements this by
> > > >> including all LCD definitions in the kernel source code, and not
> > > >> using any delays. This causes strange display artifacts on the
> > > >> display when starting up, but perhaps is harmless to the display.
> > > >> Future work will sync up the device tree more for seaboard, and thus
> tidy this up for nvidia boards.
> > > >>
> > > >> A bug in the keyboard driver is also fixed by this series. The
> > > >> series is tested on seaboard and nyan-big, the two boards I have
> > > >> which support a display.
> > > >>
> > > >> This series is available at u-boot-dm/tegra-working.
> > > >
> > > >
> > > > This changes the name of the output device from "lcd" to "vidconsole".
> > > Anyone who doesn't reset their environment to default when switching
> > > to this new U-Boot will lose their display output because of this.
> > > Is there any way to maintain compatibility?
> > > >
> > > > Aside from that, I don't see any issues on Springbank (Seaboard),
> > > > Harmony, Ventana, Paz00, or p2371-2180, so the series,
> > > > Tested-by: Stephen Warren <swarren@nvidia.com>
> > >
> > > It looks like some of the patches have been applied and all Tegra
> > > boards are now giving Kconfig warnings.
> > >
> > > Tom Warren, are you able to pick up the rest of the series?
> > I had thought these had already gone in via the dm repo. If not, please list
> those that still need to be picked up and I'll take them in via tegra. Best to
> assign the appropriate ones to me in patchwork. Currently it seems they're all
> assigned to me. Which patches have already been applied?
>
> I think it was the follow-up patches to add the environment work-around that
> was applied.
>
> 6c88b51 video: tegra: Enable the 'lcd' env variable work-around
> a2931b3 dm: video: Add a temporary work-around for old stdout var
>
> I see the original v2 series here:
>
> http://patchwork.ozlabs.org/project/uboot/list/?delegate=4839
>
> so that is what needs to be applied I think. Then the Tegra config issue should
> be fixed.
I've applied the 23 v2 DM video patches to u-boot-tegra/master, then rebased against current u-boot/master.

I see the 'warning: (TEGRA_COMMON) selects VIDCONSOLE_AS_LCD which has unmet direct dependencies (DM_VIDEO)' spew for almost every board (w/MAKEALL -s tegra).

Am I missing some patches?
--
nvpublic
>
> Regards,
> Simon