From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fastboot: sparse: fix chunk write offset calculation
Date: Wed, 3 Feb 2016 11:18:50 +0100 [thread overview]
Message-ID: <20160203101850.GF4652@lukather> (raw)
In-Reply-To: <1454402611-17864-1-git-send-email-jeffy.chen@rock-chips.com>
Hi Jeffy,
On Tue, Feb 02, 2016 at 04:43:31PM +0800, Jeffy Chen wrote:
> We should count skipped blocks in when calculating write offset.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
As I told you, this won't work in the NAND case.
If there's a bad block in the NAND, the offset will be incremented by
a block, and it won't be taken into account by the fastboot client,
and you'll end up writing on a block you already wrote to.
I guess the only solution is to make the storage backend scan the area
you skip so that it adjusts the skipped size, possibly extending it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160203/0bcc7aac/attachment.sig>
prev parent reply other threads:[~2016-02-03 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 8:43 [U-Boot] [PATCH] fastboot: sparse: fix chunk write offset calculation Jeffy Chen
2016-02-03 10:18 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203101850.GF4652@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox