From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Thu, 4 Feb 2016 13:20:50 +0100 Subject: [U-Boot] [PATCH 2/2] fastboot: sparse: remove unnecessary logging In-Reply-To: <1454532362-31109-2-git-send-email-srae@broadcom.com> References: <1454532362-31109-1-git-send-email-srae@broadcom.com> <1454532362-31109-2-git-send-email-srae@broadcom.com> Message-ID: <20160204122050.GI4270@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Steve, On Wed, Feb 03, 2016 at 12:46:02PM -0800, Steve Rae wrote: > remove logging of the 'skipped' blocks > > Signed-off-by: Steve Rae > --- > > common/image-sparse.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/common/image-sparse.c b/common/image-sparse.c > index f02aee4..594bf4e 100644 > --- a/common/image-sparse.c > +++ b/common/image-sparse.c > @@ -275,7 +275,6 @@ int store_sparse_image(sparse_storage_t *storage, void *storage_priv, > sparse_buffer_t *buffer; > uint32_t start; > uint32_t total_blocks = 0; > - uint32_t skipped = 0; > int i; > > debug("=== Storage ===\n"); > @@ -334,7 +333,6 @@ int store_sparse_image(sparse_storage_t *storage, void *storage_priv, > storage, > sparse_header); > total_blocks += blkcnt; > - skipped += blkcnt; > continue; > } > > @@ -375,8 +373,8 @@ int store_sparse_image(sparse_storage_t *storage, void *storage_priv, > sparse_put_data_buffer(buffer); > } > > - debug("Wrote %d blocks, skipped %d, expected to write %d blocks\n", > - total_blocks, skipped, > + debug("Wrote %d blocks, expected to write %d blocks\n", > + total_blocks, What's the rationale between those two patches? Do we really want to treat the DONT_CARE chunks as if they were written? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: