From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fix wrong initialization in davinci-emac driver
Date: Sat, 6 Feb 2016 15:35:12 +0100 [thread overview]
Message-ID: <20160206153512.3d2b9580@crub> (raw)
In-Reply-To: <1454768906-5468-1-git-send-email-agust@denx.de>
On Sat, 6 Feb 2016 15:28:26 +0100
Anatolij Gustschin agust at denx.de wrote:
> From: Vishwas Srivastava <vishu.kernel@gmail.com>
>
> emac module of the davinci platform supports only 8 tx and 8
> rx channels (total 16). emac driver for davinci platform,
> however, while doing initialization of the dma descriptor
> head pointers, wrongly initializes the 16 head pointers
> (instead of 8) for tx dma and 16 head pointers (insted of 8)
> for rx dma, which is wrong. The result is, that this register
> initilization spills over the other registers which was not
> intended and is undesirable. This patch fixes this problem.
>
> Signed-off-by: Vishwas Srivastava <vishu.kernel@gmail.com>
> CC: Joe Hershberger <joe.hershberger@ni.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
>
> Changes for v4:
> - slightly edit the commit message
> - prepare properly formated patch
>
> Changes for v3:
> - Added the missing patch part of v2
>
> Changes for v2:
> - cleaned up the style format
> - addressed various comments given by Joe
>
> drivers/net/davinci_emac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to u-boot-staging, thanks!
--
Anatolij
prev parent reply other threads:[~2016-02-06 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:21 [U-Boot] [PATCH v3]net: Wrong Initialization in davinci-emac driver Vishwas Srivastava
2016-02-01 16:15 ` Albert ARIBAUD
2016-02-06 14:28 ` [U-Boot] [PATCH] net: fix wrong initialization " Anatolij Gustschin
2016-02-06 14:35 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160206153512.3d2b9580@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox