From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] fastboot: sparse: remove unnecessary logging
Date: Tue, 9 Feb 2016 21:18:07 +0100 [thread overview]
Message-ID: <20160209201807.GA31506@lukather> (raw)
In-Reply-To: <CAM7GXokqPEgE4AvEwV0XDjnd4=X5AGBHLrff3ZVKv5vLjcYH0w@mail.gmail.com>
On Tue, Feb 09, 2016 at 09:58:10AM -0800, Steve Rae wrote:
> > > So, to handle MMC versus NAND, I propose that we follow the same method
> > > used throughout 'fastboot':
> > >
> > > +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
> > > total_blocks += blkcnt;
> > > +#endif
> > > +#ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV
> > > + /* TBD */
> > > +#endif
> >
> > Eventually, we should support both. But is it even broken now? It was
> > working just fine last time I tried. The write function is supposed to
> > return the adjusted number of blocks that the write actually used (bad
> > blocks included). Am I missing something?
> >
> Yes - it is broken now -- there is no "write function" in this
> CHUNK_TYPE_DONT_CARE logic....
Ah, yes, in the case where the block we skip is bad, and we should
skip yet another block.
Jeffy also had an issue with the session_id that required to honour
DONT_CARE to handle the case where you chain fastboot commands as part
of one sessions. It should probably fix this issue as well.
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160209/2dc545c2/attachment.sig>
next prev parent reply other threads:[~2016-02-09 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 20:46 [U-Boot] [PATCH 1/2] fastboot: sparse: fix block addressing for don't care chunk type Steve Rae
2016-02-03 20:46 ` [U-Boot] [PATCH 2/2] fastboot: sparse: remove unnecessary logging Steve Rae
2016-02-04 12:20 ` Maxime Ripard
2016-02-04 18:51 ` Steve Rae
2016-02-08 8:19 ` Maxime Ripard
2016-02-08 18:04 ` Steve Rae
2016-02-09 17:17 ` Maxime Ripard
2016-02-09 17:58 ` Steve Rae
2016-02-09 20:18 ` Maxime Ripard [this message]
2016-02-09 21:44 ` Steve Rae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209201807.GA31506@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox