From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Tue, 9 Feb 2016 21:18:07 +0100 Subject: [U-Boot] [PATCH 2/2] fastboot: sparse: remove unnecessary logging In-Reply-To: References: <1454532362-31109-1-git-send-email-srae@broadcom.com> <1454532362-31109-2-git-send-email-srae@broadcom.com> <20160204122050.GI4270@lukather> <20160208081916.GG31506@lukather> <20160209171742.GU31506@lukather> Message-ID: <20160209201807.GA31506@lukather> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Feb 09, 2016 at 09:58:10AM -0800, Steve Rae wrote: > > > So, to handle MMC versus NAND, I propose that we follow the same method > > > used throughout 'fastboot': > > > > > > +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV > > > total_blocks += blkcnt; > > > +#endif > > > +#ifdef CONFIG_FASTBOOT_FLASH_NAND_DEV > > > + /* TBD */ > > > +#endif > > > > Eventually, we should support both. But is it even broken now? It was > > working just fine last time I tried. The write function is supposed to > > return the adjusted number of blocks that the write actually used (bad > > blocks included). Am I missing something? > > > Yes - it is broken now -- there is no "write function" in this > CHUNK_TYPE_DONT_CARE logic.... Ah, yes, in the case where the block we skip is bad, and we should skip yet another block. Jeffy also had an issue with the session_id that required to honour DONT_CARE to handle the case where you chain fastboot commands as part of one sessions. It should probably fix this issue as well. -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: