From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] spl: if MMCSD_MODE_RAW fails, try MMCSD_MODE_FS
Date: Fri, 19 Feb 2016 15:06:07 +0200 [thread overview]
Message-ID: <20160219130607.GA814@skynet> (raw)
In-Reply-To: <1455815856-5654-1-git-send-email-guillaume.gardet@free.fr>
On Thu, Feb 18, 2016 at 06:17:36PM +0100, Guillaume GARDET wrote:
> Since commit fd61d39970b9901217efc7536d9f3a61b4e1752a:
> spl: mmc: add break statements in spl_mmc_load_image()
> RAW and FS boot modes are now exclusive again. So, if MMCSD_MODE_RAW fails, the
> board hangs. This patch allows to try MMCSD_MODE_FS then.
>
> It has been tested on a beaglebone black to boot on an EXT partition.
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Nikita Kiryanov <nikita@compulab.co.il>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Paul Kocialkowski <contact@paulk.fr>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Matwey V. Kornilov <matwey.kornilov@gmail.com>
>
> ---
> Changes in V2:
> - Replace "/* Fall through */" comment by:
> "/* If RAW mode fails, try FS mode. */"
>
> common/spl/spl_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index c3931c6..c27a250 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -284,7 +284,7 @@ int spl_mmc_load_image(u32 boot_device)
> if (!err)
> return err;
> #endif
> - break;
> + /* If RAW mode fails, try FS mode. */
> case MMCSD_MODE_FS:
> debug("spl: mmc boot mode: fs\n");
>
> --
> 1.8.4.5
>
next prev parent reply other threads:[~2016-02-19 13:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 18:27 [U-Boot] Beaglebone Black broken since commit fd61d39970b9901217efc7536d9f3a61b4e1752a Guillaume Gardet
2016-02-17 8:09 ` [U-Boot] [PATCH] spl: if MMCSD_MODE_RAW fails, try MMCSD_MODE_FS, if available Guillaume GARDET
2016-02-17 20:27 ` Tom Rini
2016-02-18 9:19 ` Nikita Kiryanov
2016-02-18 10:06 ` Guillaume Gardet
2016-02-18 13:07 ` Nikita Kiryanov
2016-02-18 13:31 ` Guillaume Gardet
2016-02-18 14:25 ` Nikita Kiryanov
2016-02-18 14:36 ` Tom Rini
2016-02-18 16:07 ` Nikita Kiryanov
2016-02-18 16:11 ` Guillaume Gardet
2016-02-18 16:38 ` Nikita Kiryanov
2016-02-18 16:42 ` Guillaume Gardet
2016-02-18 17:04 ` Tom Rini
2016-02-18 17:17 ` [U-Boot] [PATCH V2] spl: if MMCSD_MODE_RAW fails, try MMCSD_MODE_FS Guillaume GARDET
2016-02-19 13:06 ` Nikita Kiryanov [this message]
2016-02-20 0:54 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219130607.GA814@skynet \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox