From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/17] drivers: usb: musb: adopt musb backend driver to driver model
Date: Mon, 29 Feb 2016 09:43:28 -0500 [thread overview]
Message-ID: <20160229144328.GO23166@bill-the-cat> (raw)
In-Reply-To: <56D448F1.4030009@denx.de>
On Mon, Feb 29, 2016 at 02:34:41PM +0100, Marek Vasut wrote:
> On 02/29/2016 02:26 PM, Mugunthan V N wrote:
> > On Monday 29 February 2016 05:34 PM, Marek Vasut wrote:
> >> On 02/29/2016 04:44 AM, Mugunthan V N wrote:
> >>> Currently all backend driver ops uses hard coded physical
> >>> address, so to adopt the driver to DM, add device pointer to ops
> >>> call backs so that drivers that drivers can get physical
> >>> addresses from the usb driver priv/plat data.
> >>>
> >>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> >>> ---
> >>
> >> [...]
> >>
> >>> @@ -704,8 +719,13 @@ static int dsps_resume(struct device *dev)
> >>> struct omap_musb_board_data *data = plat->board_data;
> >>>
> >>> /* Start the on-chip PHY and its PLL. */
> >>> +#ifndef CONFIG_DM_USB
> >>> if (data->set_phy_power)
> >>> data->set_phy_power(1);
> >>> +#else
> >>> + if (data->set_phy_power)
> >>> + data->set_phy_power(data->dev, 1);
> >>
> >> Would it be possible to avoid adding this sea of ifdefs into the driver?
> >>
> >
> > May be introducing a void pointer and pass it back in ops callback can
> > avoid ifdefs. For non DM mode, it will be holding NULL pointer and for
> > DM mode it will be holding a dev pointer. If its ok, I can fix in v2.
>
> That looks a bit more sensible, yes. I am worried about problems with
> dereferencing the data->dev pointer though. But let's see.
Maybe looking at how Jagan has the SPI stuff separated to allow for
DM/non-DM but without a lot of ifdefs can help here too?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160229/bd36ed45/attachment.sig>
next prev parent reply other threads:[~2016-02-29 14:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 3:44 [U-Boot] [PATCH 00/17] driver model bring-up of musb on AM335x GP and BBB and usb_ether DM conversion Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 01/17] configs: am335x: usb: do not define CONFIG_DM_USB for spl Mugunthan V N
2016-03-01 1:57 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 02/17] am33xx: board: do not register usb devices when CONFIG_DM_USB is defined Mugunthan V N
2016-03-01 1:57 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 03/17] drivers: usb: musb: add ti musb misc driver for wrapper Mugunthan V N
2016-02-29 8:46 ` Mugunthan V N
2016-02-29 12:02 ` Marek Vasut
2016-02-29 13:21 ` Mugunthan V N
2016-02-29 14:42 ` Tom Rini
2016-02-29 14:42 ` Marek Vasut
2016-02-29 3:44 ` [U-Boot] [PATCH 04/17] am33xx: board: probe misc drivers to register musb devices Mugunthan V N
2016-03-01 1:58 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 05/17] drivers: usb: musb: adopt musb backend driver to driver model Mugunthan V N
2016-02-29 12:04 ` Marek Vasut
2016-02-29 13:26 ` Mugunthan V N
2016-02-29 13:34 ` Marek Vasut
2016-02-29 14:43 ` Tom Rini [this message]
2016-02-29 3:44 ` [U-Boot] [PATCH 06/17] drivers: usb: musb: add ti musb host driver with driver model support Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 07/17] drivers: usb: musb: add ti musb peripheral " Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 08/17] drivers: usb: gadget: ether: adopt to usb driver model Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 09/17] drivers: usb: gadget: ether: access network_started using local variable Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 10/17] drivers: usb: gadget: ether: consolidate global devices to single struct Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 11/17] drivers: usb: gadget: ether: use net device priv to pass usb ether priv Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 12/17] drivers: usb: gadget: ether: prepare driver for driver model migration Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 13/17] drivers: usb: gadget: ether/rndis: convert driver to adopt device driver model Mugunthan V N
2016-02-29 3:44 ` [U-Boot] [PATCH 14/17] am33xx: board: init usb ether gadget for rndis support Mugunthan V N
2016-03-01 1:58 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 15/17] am335x_evm: enable usb ether gadget as it supports DM_ETH Mugunthan V N
2016-03-01 1:58 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 16/17] defconfig: am335x_boneblack: enable usb driver model Mugunthan V N
2016-03-01 1:58 ` Tom Rini
2016-02-29 3:44 ` [U-Boot] [PATCH 17/17] defconfig: am335x_gp_evm: " Mugunthan V N
2016-03-01 1:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229144328.GO23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox