From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] Drop various features when the command line is not available
Date: Wed, 2 Mar 2016 19:58:22 -0500 [thread overview]
Message-ID: <20160303005822.GV23166@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2Dskiz31vQByLgPDpCjzP+qf3euNWtxoY7FGg6_h5G4g@mail.gmail.com>
On Wed, Mar 02, 2016 at 05:25:27PM -0700, Simon Glass wrote:
> Hi,
>
> On 29 February 2016 at 16:56, Tom Rini <trini@konsulko.com> wrote:
> > On Mon, Feb 29, 2016 at 04:47:19PM -0700, Stephen Warren wrote:
> >> On 02/25/2016 09:00 PM, Simon Glass wrote:
> >> >Some features are only useful or meaningful when the command line is
> >> >present. Ensure that these features are not compiled in when CONFIG_CMDLINE
> >> >is not enabled.
> >>
> >> How does this series affect the various code that executes other
> >> U-Boot functionality by executing commands rather than calling
> >> functions? For instance, drivers/dfu/dfu_mmc.c:mmc_file_op() calls
> >> run_command() to perform the actual disk I/O. I assume that is
> >> incompatible with enabling this new feature? If so, can Kconfig
> >> enforce that?
> >
> > This is what I was trying to get at as well. We may have to initially
> > say that some stuff is dependent on CMDLINE || BROKEN or something as we
> > have some even funkier cases for some FSL DDR things.
>
> Yes, it will break it. I'd like to think we can move to cleaning this
> stuff up though.
>
> IMO mmc_file_op() is wrong. It should work using function calls, not
> through the command-line interface. Perhaps that is hard today, and
> will get easier with driver model?
The DFU case at least was certainly more ugly at the time when doing
function calls, yes. And to start with it's not a big deal to mark some
things (even whole SoCs) as requiring CMDLINE.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160302/f2cc3420/attachment.sig>
prev parent reply other threads:[~2016-03-03 0:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 4:00 [U-Boot] [PATCH 0/9] Add CONFIG_CMDLINE to allow removal of all commands Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 1/9] cbfs: Update a function to be static Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 2/9] Add an option to enable the command line Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 3/9] arm: x86: Drop command-line code when CONFIG_CMDLINE is disabled Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not available Simon Glass
2016-02-26 17:16 ` Tom Rini
2016-02-29 23:39 ` Stephen Warren
2016-03-03 0:25 ` Simon Glass
2016-03-03 16:58 ` Stephen Warren
2016-02-26 4:00 ` [U-Boot] [PATCH 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 6/9] Hang when no command line processing can be performed Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 17:31 ` Simon Glass
2016-02-26 17:45 ` Tom Rini
2016-02-26 4:00 ` [U-Boot] [PATCH 7/9] Allow command code to compile to nothing Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-29 23:40 ` Stephen Warren
2016-03-03 0:25 ` Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 8/9] Allow command-line files to be dropped Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-26 17:31 ` Simon Glass
2016-02-26 4:00 ` [U-Boot] [PATCH 9/9] Drop various features when the command line is not available Simon Glass
2016-02-26 17:17 ` Tom Rini
2016-02-29 23:47 ` Stephen Warren
2016-02-29 23:56 ` Tom Rini
2016-03-03 0:25 ` Simon Glass
2016-03-03 0:58 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303005822.GV23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox