From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: pl01x: Add support for devices with the rate pre-configured.
Date: Mon, 7 Mar 2016 18:37:03 -0500 [thread overview]
Message-ID: <20160307233703.GD23166@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ3uS4+ctSeS-0Pd5NvK9fhnhMkbDQwVJ4ShEqtZ_7eTfA@mail.gmail.com>
On Sun, Mar 06, 2016 at 07:38:47PM -0700, Simon Glass wrote:
> Hi Stephen,
>
> On 5 March 2016 at 23:26, Stephen Warren <swarren@wwwdotorg.org> wrote:
> >
> > On 02/05/2016 09:19 PM, Stephen Warren wrote:
> >>
> >> On 02/05/2016 02:43 PM, Eric Anholt wrote:
> >>>
> >>> For Raspberry Pi, we had the input clock rate to the pl011 fixed in
> >>> the rpi.c file, but it may be changed by firmware due to user changes
> >>> to config.txt. Since the firmware always sets up the uart (default
> >>> 115200 output unless the user changes it), we can just skip our own
> >>> uart init to simplify the boot process and more reliably get serial
> >>> output.
> >>
> >>
> >> Tested-by: Stephen Warren <swarren@wwwdotorg.org>
> >> (With a 6MHz init_uart_clock and with/without init_uart_baud=9600)
> >
> >
> > Simon/Tom, did this slip through the cracks, or are you deferring it until the next release?
>
> We haven't heard back on the review comments.
>
> I don't really mind if we go the DT approach or this one. But this
> patch needs a little rework I think.
I thought the main review comment was "didn't we try and do this with
DT?" ? I'm feeling like we might want to skip doing anything DT related
for this part...
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160307/0a942334/attachment.sig>
next prev parent reply other threads:[~2016-03-07 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 21:43 [U-Boot] [PATCH] serial: pl01x: Add support for devices with the rate pre-configured Eric Anholt
2016-02-06 4:19 ` Stephen Warren
2016-03-06 6:26 ` Stephen Warren
2016-03-07 2:38 ` Simon Glass
2016-03-07 23:37 ` Tom Rini [this message]
2016-03-08 23:33 ` Simon Glass
2016-02-06 20:44 ` Simon Glass
2016-02-08 19:26 ` Sergei Temerkhanov
2016-02-08 19:45 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307233703.GD23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox