From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value
Date: Wed, 16 Mar 2016 09:27:01 +0800 [thread overview]
Message-ID: <20160316012658.GA10066@linux-7smt.suse> (raw)
In-Reply-To: <CAOMZO5DOMtH6OEZ9yjh27B5bPc7yCYYnr+9O1mqHJv8Tvi8ssA@mail.gmail.com>
Hi Fabio,
On Tue, Mar 15, 2016 at 09:53:15AM -0300, Fabio Estevam wrote:
>On Tue, Mar 15, 2016 at 2:48 AM, Peng Fan <van.freenix@gmail.com> wrote:
>> When configured a gpio to output direction, directly reading PSR register
>> can not return the output value, since we did not set SION bit for gpio
>> iomux. So, we can use data register to reflect what value is outputed.
>
>Then why not simply set the SION bit instead?
If set the SION bit, we need to change the pinmux settings in device tree,
however device tree are introduced from linux kernel. I would not like
to change the pinmux setting value.
So I choose to use data register but not PSR register.
Regards,
Peng.
next prev parent reply other threads:[~2016-03-16 1:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 5:48 [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value Peng Fan
2016-03-15 5:48 ` [U-Boot] [PATCH 2/2] dm: gpio: mxc: implement xlate function Peng Fan
2016-03-16 3:32 ` Simon Glass
2016-04-11 5:28 ` Peng Fan
2016-04-11 14:56 ` Eric Nelson
2016-03-15 12:53 ` [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value Fabio Estevam
2016-03-16 1:27 ` Peng Fan [this message]
2016-03-16 12:48 ` Fabio Estevam
2016-03-17 1:44 ` Peng Fan
2016-04-03 18:09 ` Stefano Babic
2016-04-05 5:04 ` Peng Fan
2016-04-09 18:35 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316012658.GA10066@linux-7smt.suse \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox