From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/14] mkimage: Close the file when unable to get its size
Date: Wed, 16 Mar 2016 22:09:22 -0400 [thread overview]
Message-ID: <20160317020922.GI23166@bill-the-cat> (raw)
In-Reply-To: <1458135945-13385-8-git-send-email-sjg@chromium.org>
On Wed, Mar 16, 2016 at 07:45:37AM -0600, Simon Glass wrote:
> There is a missing close() on the error path. Add it.
>
> Reported-by: Coverity (CID: 138496)
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160316/32b26755/attachment.sig>
next prev parent reply other threads:[~2016-03-17 2:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:45 [U-Boot] [PATCH 00/14] dm: Fix various issues reported by coverity Simon Glass
2016-03-16 13:45 ` [U-Boot] [PATCH 01/14] mkimage: Fix munmap() call when importing data Simon Glass
2016-03-17 2:08 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 02/14] mkimage: Correct file being closed twice in fit_import_data() Simon Glass
2016-03-17 2:08 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 03/14] mkimage: Correct file being closed twice in fit_extract_data() Simon Glass
2016-03-17 2:08 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 04/14] part_iso: Drop the customer unaligned access functions Simon Glass
2016-03-17 2:08 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 05/14] part_efi: Drop the NULL check on dev_desc in part_print_efi() Simon Glass
2016-03-17 2:08 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 06/14] part_efi: Drop NULL check in part_get_info_efi() Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 07/14] mkimage: Close the file when unable to get its size Simon Glass
2016-03-17 2:09 ` Tom Rini [this message]
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 08/14] mkimage: Add a missing free() to fit_import_data() Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 09/14] mkimage: Fix error path in fit_extract_data() Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 1:59 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 10/14] mkimage: Fix missing free() " Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 2:00 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 11/14] mkimage: Fix missing free() and close() in fit_build() Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 2:00 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 12/14] mkimage: Ensure file is closed in fdt_property_file() Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 2:00 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 13/14] mkimage: Don't close the file if it wasn't opened Simon Glass
2016-03-17 2:09 ` Tom Rini
2016-03-23 2:00 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-16 13:45 ` [U-Boot] [PATCH 14/14] usb: Correct return value in usb_stor_info() Simon Glass
2016-03-16 15:50 ` Marek Vasut
2016-03-17 2:09 ` Tom Rini
2016-03-23 2:00 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317020922.GI23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox