public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: core: device: set pinctrl state for pinctrl device
Date: Thu, 31 Mar 2016 13:26:55 +0800	[thread overview]
Message-ID: <20160331052653.GA4242@linux-7smt.suse> (raw)
In-Reply-To: <CAPnjgZ0yxON-rOt1PKWLhcRQPUCEV48XjDzj5AqkQw_UxRYXuQ@mail.gmail.com>

Hi Simon,

On Sat, Mar 12, 2016 at 07:51:47PM -0700, Simon Glass wrote:
>+Masahiro
>
>On 11 March 2016 at 22:17, Peng Fan <van.freenix@gmail.com> wrote:
>> We may have pinmux settings for pinctrl device, like the following
>> example:
>> "
>> &iomuxc {
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&pinctrl_hog_1>;
>>         imx6ul-evk {
>>                 pinctrl_hog_1: hoggrp-1 {
>>                         fsl,pins = <
>>                                 MX6UL_PAD_UART1_RTS_B__GPIO1_IO19       0x17059 /* SD1 CD */
>>                                 MX6UL_PAD_GPIO1_IO05__USDHC1_VSELECT    0x17059 /* SD1 VSELECT */
>>                                 MX6UL_PAD_GPIO1_IO09__GPIO1_IO09        0x17059 /* SD1 RESET */
>>                                 MX6UL_PAD_SNVS_TAMPER0__GPIO5_IO00      0x80000000
>>                         >;
>>                 };
>>         [......]
>> };
>> "
>>
>> We should not only select pinctrl state for non pinctrl devices, we
>> need also to handle pin mux settings such as pinctrl_log for pinctrl
>> devices.
>>
>> So at the end of probing process of pinctrl device, select the default
>> state of pinctrl device.
>>
>> Signed-off-by: Peng Fan <van.freenix@gmail.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>>  drivers/core/device.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/core/device.c b/drivers/core/device.c
>> index cb24a61..6b1ba22 100644
>> --- a/drivers/core/device.c
>> +++ b/drivers/core/device.c
>> @@ -332,6 +332,9 @@ int device_probe(struct udevice *dev)
>>         if (ret)
>>                 goto fail_uclass;
>>
>> +       if (dev->parent && device_get_uclass_id(dev) == UCLASS_PINCTRL)
>> +               pinctrl_select_state(dev, "default");
>> +
>>         return 0;
>>  fail_uclass:
>>         if (device_remove(dev)) {
>> --
>> 2.6.2
>>
>
>Reviewed-by: Simon Glass <sjg@chromium.org>

Will you pick up this patch?

Thanks,
Peng.

  reply	other threads:[~2016-03-31  5:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12  5:17 [U-Boot] [PATCH] dm: core: device: set pinctrl state for pinctrl device Peng Fan
2016-03-13  2:51 ` Simon Glass
2016-03-31  5:26   ` Peng Fan [this message]
2016-04-06  2:45     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331052653.GA4242@linux-7smt.suse \
    --to=van.freenix@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox