From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code
Date: Mon, 4 Apr 2016 19:59:56 -0400 [thread overview]
Message-ID: <20160404235956.GS23166@bill-the-cat> (raw)
In-Reply-To: <1459794709-21601-1-git-send-email-hdegoede@redhat.com>
On Mon, Apr 04, 2016 at 08:31:48PM +0200, Hans de Goede wrote:
> v7_maint_dcache_all() does not work reliable when build with gcc6,
> see: https://bugzilla.redhat.com/show_bug.cgi?id=1318788
So, I see on the bug you want to know if U-Boot is OK with this patch
series being the fix. At the high level, yes, borrowing code from the
Linux Kernel is a good clean-up and I'd like to see this series could
clean up things a little more and borrow from cache-v7.S when we could.
But I'd also push back on the toolchain team. Are they happy saying
"that code is just too fragile, it's probably relying on undefined
behavior, investigation concluded" ?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160404/906221b5/attachment.sig>
next prev parent reply other threads:[~2016-04-04 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:31 [U-Boot] [PATCH 1/2] arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code Hans de Goede
2016-04-04 18:31 ` [U-Boot] [PATCH 2/2] arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_INVAL_ALL) " Hans de Goede
2016-04-04 23:59 ` Tom Rini [this message]
2016-04-05 8:33 ` [U-Boot] [PATCH 1/2] arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) " Hans de Goede
2016-04-05 8:44 ` Hans de Goede
2016-04-05 13:45 ` Tom Rini
2016-04-06 2:07 ` Masahiro Yamada
2016-04-06 14:51 ` Tom Rini
2016-04-06 15:22 ` Hans de Goede
2016-04-06 15:27 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404235956.GS23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox