public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: g_dnl: Change device class
Date: Fri, 08 Apr 2016 11:19:34 +0200	[thread overview]
Message-ID: <20160408111934.64e7f21b@amdc2363> (raw)
In-Reply-To: <1460072943-77066-1-git-send-email-john.tobias.ph@gmail.com>

Hi John,

> The USB Mass Storage (ums) works in Windows, Linux and OS X (EL
> Capitan). But, not in OS X (Yosemite). By applying the said patch, it
> extends the ums support.
> 
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
>  drivers/usb/gadget/g_dnl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> index 2fa6da4..bd3aad9 100644
> --- a/drivers/usb/gadget/g_dnl.c
> +++ b/drivers/usb/gadget/g_dnl.c
> @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = {
>  	.bDescriptorType = USB_DT_DEVICE,
>  
>  	.bcdUSB = __constant_cpu_to_le16(0x0200),
> -	.bDeviceClass = USB_CLASS_COMM,
> -	.bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/
> +	.bDeviceClass = USB_CLASS_PER_INTERFACE,
> +	.bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/

Have you tested if this patch is not introducing any regression on
Linux and Windows?

>  
>  	.idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM),
>  	.idProduct =
> __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM),



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2016-04-08  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 23:49 [U-Boot] [PATCH] USB: g_dnl: Change device class John Tobias
2016-04-08  9:19 ` Lukasz Majewski [this message]
2016-04-08 15:41   ` John Tobias
2016-04-08 20:12     ` Lukasz Majewski
2016-04-11 11:21 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408111934.64e7f21b@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox