From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 08 Apr 2016 11:19:34 +0200 Subject: [U-Boot] [PATCH] USB: g_dnl: Change device class In-Reply-To: <1460072943-77066-1-git-send-email-john.tobias.ph@gmail.com> References: <1460072943-77066-1-git-send-email-john.tobias.ph@gmail.com> Message-ID: <20160408111934.64e7f21b@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi John, > The USB Mass Storage (ums) works in Windows, Linux and OS X (EL > Capitan). But, not in OS X (Yosemite). By applying the said patch, it > extends the ums support. > > Signed-off-by: John Tobias > --- > drivers/usb/gadget/g_dnl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c > index 2fa6da4..bd3aad9 100644 > --- a/drivers/usb/gadget/g_dnl.c > +++ b/drivers/usb/gadget/g_dnl.c > @@ -58,8 +58,8 @@ static struct usb_device_descriptor device_desc = { > .bDescriptorType = USB_DT_DEVICE, > > .bcdUSB = __constant_cpu_to_le16(0x0200), > - .bDeviceClass = USB_CLASS_COMM, > - .bDeviceSubClass = 0x02, /*0x02:CDC-modem , 0x00:CDC-serial*/ > + .bDeviceClass = USB_CLASS_PER_INTERFACE, > + .bDeviceSubClass = 0, /*0x02:CDC-modem , 0x00:CDC-serial*/ Have you tested if this patch is not introducing any regression on Linux and Windows? > > .idVendor = __constant_cpu_to_le16(CONFIG_G_DNL_VENDOR_NUM), > .idProduct = > __constant_cpu_to_le16(CONFIG_G_DNL_PRODUCT_NUM), -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group