From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers: mmc: omap_hsmmc: Fix conversion of address to a pointer
Date: Fri, 8 Apr 2016 15:45:22 -0400 [thread overview]
Message-ID: <20160408194522.GH23166@bill-the-cat> (raw)
In-Reply-To: <1459763569-29226-1-git-send-email-mugunthanvnm@ti.com>
On Mon, Apr 04, 2016 at 03:22:49PM +0530, Mugunthan V N wrote:
> omap_hsmmc driver directly typecasts fdt_addr_t to a pointer.
> This is not strictly correct, as it gives a build warning when
> fdt_addr_t is u64. So, use map_physmem for a proper typecasts.
>
> This is inspired by commit 167efe01bc5a9 ("dm: ns16550: Use an address
> instead of a pointer for the uart base")
>
> drivers/mmc/omap_hsmmc.c: In function ?omap_hsmmc_ofdata_to_platdata?:
> drivers/mmc/omap_hsmmc.c:776:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> priv->base_addr = (struct hsmmc *)dev_get_addr(dev);
> ^
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160408/e162815d/attachment.sig>
next prev parent reply other threads:[~2016-04-08 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 9:52 [U-Boot] [PATCH] drivers: mmc: omap_hsmmc: Fix conversion of address to a pointer Mugunthan V N
2016-04-08 19:45 ` Tom Rini [this message]
2016-04-21 11:20 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408194522.GH23166@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox