From: Beniamino Galvani <b.galvani@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 9/9] board: odroid-c2: add Ethernet support
Date: Sun, 10 Apr 2016 17:35:17 +0200 [thread overview]
Message-ID: <20160410153434.GA16480@gmail.com> (raw)
In-Reply-To: <CANr=Z=ZUtgNfQ_pPmf1ehfPsphV2LyAV6yJrt_XVTJtCWzyCCA@mail.gmail.com>
On Sun, Apr 03, 2016 at 07:20:10PM -0500, Joe Hershberger wrote:
> > +#ifdef CONFIG_MISC_INIT_R
> > +int misc_init_r(void)
> > +{
> > + /* Select Ethernet function */
> > + setbits_le32(GXBB_PINMUX_6, 0x3fff);
> > +
> > + /* Set RGMII mode */
> > + setbits_le32(GXBB_ETH_REG_0, 0x1621);
>
> It would be good to have constants for all these magic numbers.
>
> > +
> > + /* Enable clocks */
> > + setbits_le32(GXBB_GCLK_MPEG_1, 1 << 3);
>
> Use the BIT() macro for this type of thing. Probably use the BIT()
> macro in another named macro for the meaning of the magic bit.
I updated known values with macros in v3 (but left 0x3fff as is
because its meaning is not documented). Thanks!
Beniamino
prev parent reply other threads:[~2016-04-10 15:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 7:18 [U-Boot] [PATCH v2 0/9] Amlogic Meson GXBaby and ODROID-C2 support Beniamino Galvani
2016-04-03 7:18 ` [U-Boot] [PATCH v2 1/9] arm: add initial support for Amlogic Meson and ODROID-C2 Beniamino Galvani
2016-04-03 16:08 ` Tom Rini
2016-04-03 7:18 ` [U-Boot] [PATCH v2 2/9] arm: dts: import Meson files Beniamino Galvani
2016-04-03 16:08 ` Tom Rini
2016-04-03 7:18 ` [U-Boot] [PATCH v2 3/9] serial: add support for Amlogic Meson UART Beniamino Galvani
2016-04-03 16:08 ` Tom Rini
2016-04-03 7:18 ` [U-Boot] [PATCH v2 4/9] arm: meson: use device tree Beniamino Galvani
2016-04-03 16:09 ` Tom Rini
2016-04-03 7:18 ` [U-Boot] [PATCH v2 5/9] board: odroid-c2: enable serial Beniamino Galvani
2016-04-03 16:09 ` Tom Rini
2016-04-03 20:18 ` Beniamino Galvani
2016-04-03 7:18 ` [U-Boot] [PATCH v2 6/9] net: designware: fix descriptor layout and warnings on 64-bit archs Beniamino Galvani
2016-04-03 16:09 ` Tom Rini
2016-04-04 0:04 ` Joe Hershberger
2016-04-03 7:18 ` [U-Boot] [PATCH v2 7/9] net: designware: add generic device tree compatible id Beniamino Galvani
2016-04-03 16:09 ` Tom Rini
2016-04-04 0:13 ` Joe Hershberger
2016-04-03 7:18 ` [U-Boot] [PATCH v2 8/9] arm: dts: add ethernet node to Meson gxbb Beniamino Galvani
2016-04-03 9:12 ` Carlo Caione
2016-04-03 14:45 ` Tom Rini
2016-04-03 16:09 ` Tom Rini
2016-04-03 20:17 ` Beniamino Galvani
2016-04-04 4:47 ` Tom Rini
2016-04-03 7:18 ` [U-Boot] [PATCH v2 9/9] board: odroid-c2: add Ethernet support Beniamino Galvani
2016-04-03 16:09 ` Tom Rini
2016-04-04 0:20 ` Joe Hershberger
2016-04-10 15:35 ` Beniamino Galvani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410153434.GA16480@gmail.com \
--to=b.galvani@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox