From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peng Fan <van.freenix@gmail.com>
Date: Mon, 11 Apr 2016 13:45:46 +0800
Subject: [U-Boot] [PATCH 1/2] dm: spi: soft_spi: support linux way and
	bug fix
In-Reply-To: <CAPnjgZ2oL55SEjVEojT+umnBg1Rgb6AgWf-=xeOAdVSr7+dQXg@mail.gmail.com>
References: <1458548978-8741-1-git-send-email-van.freenix@gmail.com>
 <CAPnjgZ2oL55SEjVEojT+umnBg1Rgb6AgWf-=xeOAdVSr7+dQXg@mail.gmail.com>
Message-ID: <20160411054545.GD8379@linux-7smt.suse>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Sat, Apr 09, 2016 at 12:33:37PM -0600, Simon Glass wrote:
>Hi Peng,
>
>On 21 March 2016 at 02:29, Peng Fan <van.freenix@gmail.com> wrote:
>> 1. Support compatible string "spi-gpio" which is used by Linux
>>    Linux use different bindings, so use UBOOT_COMPAT and
>>    LINUX_COMPAT to differentiate them.
>
>There is only one user - instead of this, can you please drop the
>U-Boot binding and move the universal board over to use your new
>binding? There should be only one.


Ok. Will drop the U-Boot binding.

>
>> 2. Bug fix
>>    When doing xfer, should use device->parent, but not device
>>    When doing bit xfer, should use "!!(tmpdout & 0x80)", but not
>>    "(tmpdout & 0x80)"
>> 3. Introduce SPI_MASTER_NO_RX and SPI_MASTER_NO_TX to handle
>>    no rx or no tx case.
>
>Perhaps put these two in separate patches?


Will try it.

Thanks,
Peng.

>
>> 4. Tested on i.MX6 UltraLite board with 74LV595 spi-gpio chip.
>>
>> Signed-off-by: Peng Fan <van.freenix@gmail.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Jagan Teki <jteki@openedev.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>>  drivers/spi/soft_spi.c | 75 ++++++++++++++++++++++++++++++++++++++------------
>>  1 file changed, 57 insertions(+), 18 deletions(-)
>
>Regards,
>Simon