public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] net: designware: fix descriptor layout and warnings on 64-bit archs
Date: Mon, 11 Apr 2016 22:46:20 +0200	[thread overview]
Message-ID: <20160411204620.GA22294@gmail.com> (raw)
In-Reply-To: <570AE8FF.5000509@gmail.com>

On Mon, Apr 11, 2016 at 01:59:59AM +0200, Marek Vasut wrote:
> 
> This looks more like silencing the warning by a forced cast.
> The pointer should most likely be sanity-checked to make sure it's in
> 4GiB address space at least. I am worried such forced casts will bite
> us in the long run.

Yes, this patch assumes that addresses of buffers and descriptors are
in the first 4GiB of address space. AFAIU this should be a safe
premise for current SoCs, since the physical memory is always mapped
within the 32bit addressable range; other drivers (see for example
sunxi_mmc) do a similar assumption.

So, right now I don't think a check is strictly needed, but to be
future-proof probably it wouldn't hurt either.

Beniamino

  reply	other threads:[~2016-04-11 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-10 15:30 [U-Boot] [PATCH v3 0/2] Amlogic Meson GXBaby and ODROID-C2 support Beniamino Galvani
2016-04-10 15:30 ` [U-Boot] [PATCH v3 1/2] net: designware: fix descriptor layout and warnings on 64-bit archs Beniamino Galvani
2016-04-10 23:59   ` Marek Vasut
2016-04-11 20:46     ` Beniamino Galvani [this message]
2016-04-10 15:30 ` [U-Boot] [PATCH v3 2/2] arm: add initial support for Amlogic Meson and ODROID-C2 Beniamino Galvani
2016-04-11  0:08   ` Marek Vasut
2016-04-11 21:02     ` Beniamino Galvani
2016-04-11 21:08       ` Marek Vasut
2016-04-12 21:50         ` Beniamino Galvani
2016-04-12 22:26           ` Marek Vasut
2016-04-13 11:22             ` Beniamino Galvani
2016-04-13 11:52               ` Marek Vasut
2016-04-13 21:38                 ` Alexander Graf
2016-04-13 22:34                   ` Tom Rini
2016-04-13 22:42                     ` Alexander Graf
2016-04-13 22:51                       ` Tom Rini
2016-04-13 22:53                         ` Alexander Graf
2016-04-13 23:12                           ` Marek Vasut
2016-04-14  7:08                             ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160411204620.GA22294@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox