From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 19 Apr 2016 11:02:43 +0200 Subject: [U-Boot] [PATCH 2/3] usb: s3c-otg: Fix short packet for request size > ep.maxpacket In-Reply-To: <1461050221-9268-3-git-send-email-rogerq@ti.com> References: <1461050221-9268-1-git-send-email-rogerq@ti.com> <1461050221-9268-3-git-send-email-rogerq@ti.com> Message-ID: <20160419110243.577c277a@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Roger, > Request size can be greater than ep.packet and still end in a > short packet. We need to tackle this case as end of transfer > (if short_not_ok is not set) as indicated in USB 2.0 Specification > [1], else we get stuck up on certain protocols like fastboot. > > [1] - USB2.0 Specification, Section 5.3.2 Pipes > > Reported-by: Steve Rae > Signed-off-by: Roger Quadros > Tested-by: Steve Rae > --- > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c > b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c index bce9c30..a31d875 > 100644 --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c > +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c > @@ -229,7 +229,7 @@ static void complete_rx(struct dwc2_udc *dev, u8 > ep_num) ROUND(xfer_size, CONFIG_SYS_CACHELINE_SIZE)); > > req->req.actual += min(xfer_size, req->req.length - > req->req.actual); > - is_short = (xfer_size < ep->ep.maxpacket); > + is_short = xfer_size % ep->ep.maxpacket; is_short is a flag - so maybe it would be better to write something like: is_short = !!(xfer_size % ep->ep.maxpacket)) ? I'm going to test those patches on my boards. I will share the results ASAP. > > debug_cond(DEBUG_OUT_EP != 0, > "%s: RX DMA done : ep = %d, rx bytes = %d/%d, " -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group