From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Tue, 19 Apr 2016 18:30:12 +0200
Subject: [U-Boot] [PATCH v2 1/3] tests: py: dfu: Add global variables to
 store dfu alt numbers for test and dummy files
In-Reply-To: <57165B3D.20606@wwwdotorg.org>
References: <1460130291-24223-1-git-send-email-l.majewski@samsung.com>
 <1461081084-16649-1-git-send-email-l.majewski@samsung.com>
 <57165B3D.20606@wwwdotorg.org>
Message-ID: <20160419183012.4e26b7df@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stephen,

> On 04/19/2016 09:51 AM, Lukasz Majewski wrote:
> > This patch replaces hardcoded (i.e. 0 and 1) values passed to
> > dfu_{read|write} with global variables.
> 
> Why do these variables need to be global? They're only used inside 
> test_dfu(). They should be local to that function.
> 

Ok, I will fix that.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group