U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd/usb_mass_storage.c: Rework ums_init() ret logic slightly
Date: Thu, 21 Apr 2016 07:27:19 -0400	[thread overview]
Message-ID: <20160421112719.GH3732@bill-the-cat> (raw)
In-Reply-To: <1461164516-28568-1-git-send-email-trini@konsulko.com>

On Wed, Apr 20, 2016 at 11:01:56AM -0400, Tom Rini wrote:

> Previously, ret could be used uninitialized if
> blk_get_device_part_str() failed.  Default to ret being set to -1 so
> that we always return an err up if we have a problem and then invert the
> logic on testing ums_count as when that is non-zero is the time we can
> return 0.
> 
> Cc: John Tobias <john.tobias.ph@gmail.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>

With the brace changes Marek suggested, applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/b35fe71e/attachment.sig>

  parent reply	other threads:[~2016-04-21 11:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20  9:45 [U-Boot] [PULL] u-boot-usb/master Marek Vasut
2016-04-20 15:01 ` [U-Boot] [PATCH] cmd/usb_mass_storage.c: Rework ums_init() ret logic slightly Tom Rini
2016-04-20 15:46   ` Marek Vasut
2016-04-20 17:20     ` Tom Rini
2016-04-21 11:27   ` Tom Rini [this message]
2016-04-21 11:26 ` [U-Boot] [PULL] u-boot-usb/master Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160421112719.GH3732@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox