From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Thu, 21 Apr 2016 12:04:34 +0200
Subject: [U-Boot] [PATCH v2 2/3] usb: s3c-otg: Fix short packet for
 request size > ep.maxpacket
In-Reply-To: <57162297.2030309@ti.com>
References: <1461050221-9268-1-git-send-email-rogerq@ti.com>
 <1461050221-9268-3-git-send-email-rogerq@ti.com> <57162297.2030309@ti.com>
Message-ID: <20160421120434.6732cc31@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Roger,

> Request size can be greater than ep.packet and still end in a
> short packet. We need to tackle this case as end of transfer
> (if short_not_ok is not set) as indicated in USB 2.0 Specification
> [1], else we get stuck up on certain protocols like fastboot.
> 
> [1] - USB2.0 Specification, Section 5.3.2 Pipes
> 
> Reported-by: Steve Rae <steve.rae@broadcom.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Tested-by: Steve Rae <steve.rae@broadcom.com>
> ---
>  drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c index bce9c30..9aa0f33
> 100644 --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> @@ -229,7 +229,7 @@ static void complete_rx(struct dwc2_udc *dev, u8
> ep_num) ROUND(xfer_size, CONFIG_SYS_CACHELINE_SIZE));
>  
>  	req->req.actual += min(xfer_size, req->req.length -
> req->req.actual);
> -	is_short = (xfer_size < ep->ep.maxpacket);
> +	is_short = !!(xfer_size % ep->ep.maxpacket);
>  
>  	debug_cond(DEBUG_OUT_EP != 0,
>  		   "%s: RX DMA done : ep = %d, rx bytes = %d/%d, "

Tested-by: Lukasz Majewski <l.majewski@samsung.com>

Test HW: Odroid U3 (Exynos 4412)

Test: ./test/py DFU & UMS

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group