public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: ram: fix number base of RAM entity parameters
Date: Mon, 25 Apr 2016 09:28:06 +0200	[thread overview]
Message-ID: <20160425092806.096eb8bf@amdc2363> (raw)
In-Reply-To: <571DBBCD.9020003@ti.com>

Hi Mugunthan,

> On Saturday 23 April 2016 01:04 AM, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> > 
> > U-Boot typically interprets unprefixed numbers as base 16, and DFU
> > RAM entity parsing has historically done so. Reverse the change to
> > default to base 10, so that values in previously working
> > command-lines aren't mis-parsed, causing RAM corruption, crashes,
> > hangs, etc.
> > 
> > Fixes: 6aeb877afef0 ("drivers: dfu: ram: fix a crash with dfu ram
> > with invalid dfu_alt_info env")
> > 
> > Cc: Mugunthan V N <mugunthanvnm@ti.com>
> > Cc: Tom Rini <trini@konsulko.com>
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> 
> Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>

I assume that you have also tested this patch on your setup?

Would it be possible to also receive Tested-by: from you?

> 
> Regards
> Mugunthan V N
> 
> 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2016-04-25  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 19:34 [U-Boot] [PATCH] dfu: ram: fix number base of RAM entity parameters Stephen Warren
2016-04-25  6:40 ` Mugunthan V N
2016-04-25  7:28   ` Lukasz Majewski [this message]
2016-04-25  8:47     ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425092806.096eb8bf@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox