* [U-Boot] [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition
@ 2016-04-25 19:25 Martin Pietryka
2016-04-25 20:05 ` Anatolij Gustschin
2016-04-26 5:45 ` [U-Boot] Antwort: " Hannes Schmelzer
0 siblings, 2 replies; 3+ messages in thread
From: Martin Pietryka @ 2016-04-25 19:25 UTC (permalink / raw)
To: u-boot
According to the TRM you have to set bits [21:20] to 0b10 for RAW mode, so
(0x10 << 20) is obviously wrong here.
Signed-off-by: Martin Pietryka <martin.pietryka@chello.at>
---
drivers/video/am335x-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
index e23d172..0ec843f 100644
--- a/drivers/video/am335x-fb.c
+++ b/drivers/video/am335x-fb.c
@@ -55,7 +55,7 @@
/* LCD Raster Ctrl Register */
#define LCD_TFT_24BPP_MODE (1 << 25)
#define LCD_TFT_24BPP_UNPACK (1 << 26)
-#define LCD_PALMODE_RAWDATA (0x10 << 20)
+#define LCD_PALMODE_RAWDATA (0x02 << 20)
#define LCD_TFT_MODE (0x01 << 7)
#define LCD_RASTER_ENABLE (0x01 << 0)
--
2.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition
2016-04-25 19:25 [U-Boot] [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition Martin Pietryka
@ 2016-04-25 20:05 ` Anatolij Gustschin
2016-04-26 5:45 ` [U-Boot] Antwort: " Hannes Schmelzer
1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2016-04-25 20:05 UTC (permalink / raw)
To: u-boot
On Mon, 25 Apr 2016 21:25:07 +0200
Martin Pietryka martin.pietryka at chello.at wrote:
> According to the TRM you have to set bits [21:20] to 0b10 for RAW mode, so
> (0x10 << 20) is obviously wrong here.
>
> Signed-off-by: Martin Pietryka <martin.pietryka@chello.at>
> ---
> drivers/video/am335x-fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-video/master. Thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] Antwort: [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition
2016-04-25 19:25 [U-Boot] [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition Martin Pietryka
2016-04-25 20:05 ` Anatolij Gustschin
@ 2016-04-26 5:45 ` Hannes Schmelzer
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Schmelzer @ 2016-04-26 5:45 UTC (permalink / raw)
To: u-boot
>
> According to the TRM you have to set bits [21:20] to 0b10 for RAW mode,
so
> (0x10 << 20) is obviously wrong here.
>
> Signed-off-by: Martin Pietryka <martin.pietryka@chello.at>
> ---
> drivers/video/am335x-fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/am335x-fb.c b/drivers/video/am335x-fb.c
> index e23d172..0ec843f 100644
> --- a/drivers/video/am335x-fb.c
> +++ b/drivers/video/am335x-fb.c
> @@ -55,7 +55,7 @@
> /* LCD Raster Ctrl Register */
> #define LCD_TFT_24BPP_MODE (1 << 25)
> #define LCD_TFT_24BPP_UNPACK (1 << 26)
> -#define LCD_PALMODE_RAWDATA (0x10 << 20)
> +#define LCD_PALMODE_RAWDATA (0x02 << 20)
> #define LCD_TFT_MODE (0x01 << 7)
> #define LCD_RASTER_ENABLE (0x01 << 0)
>
> --
> 2.8.0
Reviewed-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-26 5:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 19:25 [U-Boot] [PATCH] drivers/video/am335x-fb: Fix bits for LCD_PALMODE_RAWDATA definition Martin Pietryka
2016-04-25 20:05 ` Anatolij Gustschin
2016-04-26 5:45 ` [U-Boot] Antwort: " Hannes Schmelzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox