[U-Boot] [PATCH 01/60] ARM: tegra: remove unused definitions in headers

Simon Glass
2016-04-25T22:15:56Z

Hi Stephen,

On 25 April 2016 at 16:02, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 04/25/2016 03:54 PM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 25 April 2016 at 13:34, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>
>>>
>>> On 04/24/2016 04:20 AM, Wolfgang Denk wrote:
>>>>
>>>>
>>>> Dear Stephen,
>>>>
>>>> In message <1461099580-3866-2-git-send-email-swarren@wwwdotorg.org> you
>>>> wrote:
>>>>>
>>>>>
>>>>>
>>>> ...
>>>>>
>>>>>
>>>>> /*
>>>>> * Copyright (c) 2011 The Chromium OS Authors.
>>>>> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
>>>>
>>>>
>>>>
>>>> Can you please get rid of this "All rights reserved." ?
>>>
>>>
>>>
>>> Sorry, that is the format I'm required to use by NVIDIA legal.
>>>
>>> To address your next question, "all rights reserved" is 100% compatible
>>> with OSS licenses. Equally, the phrase already exists throughout both the
>>> U-Boot and Linux kernel code-base (just a couple of prominent examples) for
>>> both NVIDIA's copyright notices, and those of many other prominent entities
>>> such as The Linux Foundation, Red Hat, Intel, The Chromium OS Authors, etc.
>>>
>>>> Please fix this globally in the whole patch set.
>>>>
>>>> I assume it cannot be a problem to do that, as in other places you did
>>>> not add this either, for example here:
>>>>
>>>>> --- a/arch/arm/include/asm/arch-tegra/gp_padctrl.h
>>>>> +++ b/arch/arm/include/asm/arch-tegra/gp_padctrl.h
>>>>> @@ -1,6 +1,6 @@
>>>>> /*
>>>>> - * (C) Copyright 2010-2015
>>>>> - * NVIDIA Corporation <www.nvidia.com>
>>>>> + * (C) Copyright 2010-2016
>>>>> + * NVIDIA Corporation <www.nvidia.com>
>>>
>>>
>>>
>>> The primary purpose of this patch-set isn't to clean up copyright
>>> notices. As such, where I added new copyright notices I followed the format
>>> that NVIDIA legal requests me to. However, where I simply edited the date in
>>> existing notices I didn't do any other cleanup.
>>
>>
>> Perhaps you could consider just not updating the notices? It isn't
>> required by U-Boot. I tend not to do it.
>>
>> Also the all rights reserved thing is apparently pointless.
>
>
> NVIDIA legal says I have to.
>
> I believe the only choice I have is whether to contribute to U-Boot.
>
> That said, I will go and double check again.

Also point them to this:

https://en.wikipedia.org/wiki/All_rights_reserved

I recall a similar discussion before...

Regards,
Simon