[U-Boot] [PATCH 54/60] video: tegra: move pinmux setup to board files

Simon Glass
2016-05-07T22:32:25Z

On 19 April 2016 at 14:59, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Remove funcmux calls from the Tegra20 video driver. Knowledge of pinmux
> setup must come from either board files or DT; it should not be embedded
> into board-agnostic driver code. The DT pinmux bindings do not allow
> drivers to derive funcmux-style information, since the DT bindings are
> pin-based whereas funcmux is controller-based, so there's no good way to
> call the existing funcmux APIs from drivers. Converting drivers to use a
> new (as yet non-existent in U-Boot) API that pulls pinmux information from
> DT isn't useful for Tegra, since Tegra's DT files don't contain any
> per-device pinmux tables, so this would simply be extra code that has no
> effect; doesn't actually set up the pinmux. We are left with moving the
> pinmux setup functionality into board files. In theory the board files
> could be converted later to use DT, but that would be a separate change.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> board/avionic-design/common/tamonten.c | 1 +
> board/compal/paz00/paz00.c | 3 +++
> board/nvidia/harmony/harmony.c | 1 +
> board/nvidia/seaboard/seaboard.c | 1 +
> board/toradex/colibri_t20/colibri_t20.c | 1 +
> drivers/video/tegra.c | 3 ---
> 6 files changed, 7 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>