From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] spl_mmc: allow to load raw image
Date: Sun, 1 May 2016 09:46:20 -0400 [thread overview]
Message-ID: <20160501134620.GD7884@bill-the-cat> (raw)
In-Reply-To: <CAK7LNASRfYDqTfPDzBmJzXYQDuMddZVH+wsALBRxUBFQZvMbwA@mail.gmail.com>
On Sun, May 01, 2016 at 05:37:42PM +0900, Masahiro Yamada wrote:
> Hi Adam,
>
>
> 2016-04-30 3:06 GMT+09:00 Adam Ford <aford173@gmail.com>:
> > On Fri, Apr 29, 2016 at 12:53 PM, Tom Rini <trini@konsulko.com> wrote:
> >> On Fri, Apr 29, 2016 at 09:59:00AM -0500, Adam Ford wrote:
> >>
> >>> Does anyone with an OMAP3 board have any issues with this patch? I
> >>> will admit I haven't stayed on top of stuff due to moving, and other
> >>> issues at home, but I pulled down the master to reviews some on
> >>> related stuff, and found that master doesn't boot. I used git bisect
> >>> this morning and it narrowed down a problem with booting to this
> >>> patch.
> >>>
> >>> With the patch, I get:
> >>>
> >>> U-Boot SPL 2016.03-00378-g4976f48 (Apr 29 2016 - 09:25:27)
> >>> Trying to boot from MMC
> >>
> >> OK. Do you have u-boot.bin or u-boot.img (which?) written to the raw
> >> offset in MMC or from filesystem? Based on the log it looks like
> >> filesystem.
> >
> > I have u-boot.img copied to the fatfs on the card, but I didn't put it
> > in a specific location.
> >
> > I never used to have to do that. Is this a new behavior and is it
> > documented somewhere?
> >
> > adam
>
>
> You are expecting to boot it from FAT,
> but I think spl_boot_mode() on your board returns MMCSD_MODE_RAW.
>
> Can you fix the function to return MMCSD_MODE_FS?
>
>
>
> This commit changed to allow to load raw U-Boot image,
> so MMCSD_MODE_RAW never fails.
>
> So, you can no longer rely on the former behavior
> "try MMCSD_MODE_RAW first, and fallback to MMCSD_MODE_FS".
Well, I forgot to ask, is MLO being loaded from FAT or from raw?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160501/b6938763/attachment.sig>
next prev parent reply other threads:[~2016-05-01 13:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:31 [U-Boot] [PATCH] spl_mmc: allow to load raw image Masahiro Yamada
2016-03-01 1:58 ` Tom Rini
2016-03-15 19:23 ` [U-Boot] " Tom Rini
2016-03-16 3:10 ` Masahiro Yamada
2016-03-17 2:04 ` Tom Rini
2016-03-17 16:07 ` Masahiro Yamada
2016-03-17 16:12 ` Tom Rini
2016-04-29 14:59 ` Adam Ford
2016-04-29 17:53 ` Tom Rini
2016-04-29 18:06 ` Adam Ford
2016-04-29 18:06 ` Tom Rini
2016-05-01 8:37 ` Masahiro Yamada
2016-05-01 13:46 ` Tom Rini [this message]
2016-05-02 1:32 ` Derald D. Woods
2016-05-02 1:57 ` Tom Rini
2016-05-02 2:04 ` Masahiro Yamada
2016-05-02 2:17 ` Derald D. Woods
2016-05-02 2:29 ` Derald D. Woods
2016-05-02 7:08 ` Alexander Graf
2016-05-02 12:44 ` Tom Rini
2016-05-02 7:35 ` Alexander Graf
2016-05-02 8:58 ` Guillaume Gardet
2016-05-02 9:12 ` Alexander Graf
2016-05-02 9:45 ` Guillaume Gardet
2016-05-02 11:21 ` Alexander Graf
2016-05-02 16:14 ` Tom Rini
2016-05-02 21:19 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501134620.GD7884@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox