From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 2 May 2016 12:14:05 -0400 Subject: [U-Boot] spl_mmc: allow to load raw image In-Reply-To: <572719EB.6090306@suse.de> References: <20160429175350.GZ19598@bill-the-cat> <20160502015758.GI7884@bill-the-cat> <1ecbd1aa-7176-1240-dd50-56f4a5141c88@gmail.com> <3c04eb68-0f7d-1927-ad53-8bc8e9c60f1f@suse.de> <57271698.8090302@free.fr> <572719EB.6090306@suse.de> Message-ID: <20160502161405.GK7884@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 02, 2016 at 11:12:11AM +0200, Alexander Graf wrote: [snip] > So Tom, how would you like to roll this? We can either > > 1) Check raw after fs, default to fs and revert my patch or > 2) Leave fs boot broken (regression) or > 3) Leave raw boot broken (same as 2016.03) > > Given that release is in 1 week, I'm wary on option 1. I also don't > like regressions. So how about we revert my patch and fix it up with > fs-before-raw boot for 2016.07? So, we need to revert ef5ebe951bec72 which is what changed the raw offset. I think we also need to revert 22d90d560a2b which yes, will go back to breaking raw MLO + FS U-Boot. The problem here is that we have the fallback case of "load hard-coded size from MMC, assume u-boot.bin is raw". So raw will never fail. Marek posted a series late last week that would address this by letting us say that we want to call an invalid signature for U-Boot bad and continue on to other methods. I'm wondering if this doesn't go far enough actually and we should say that unless specifically set (like CONFIG_SPL_NAND_RAW_ONLY does), we don't assume it's good. It's been a long time since we didn't default to making a u-boot.img and SPL has "always" supported both. It was mainly legacy code for letting people mix-and-match SPL + X-Loader (and go back and forth). I'm leaning towards making this an opt-in thing and introduce CONFIG_SPL_MMC_BIN_ONLY (and rename the NAND one) as the logic is getting really really convoluted now. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: