public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2
Date: Sun, 8 May 2016 08:35:16 +0200	[thread overview]
Message-ID: <20160508063516.GA3222@gmail.com> (raw)
In-Reply-To: <CAPnjgZ2-g2YYfBoHMfV2An3GOX2gU_fuG+mOYZAtkowrs5mq7Q@mail.gmail.com>

On Sun, May 01, 2016 at 12:56:21PM -0600, Simon Glass wrote:
> > +config ARCH_MESON
> > +       bool "Amlogic Meson"
> 
> Please add a help message describing what this is and what features it has.

Fixed in v7.

> > +       /* Reset PHY on GPIOZ_14 */
> > +       clrbits_le32(GXBB_GPIO_EN(3), BIT(14));
> > +       clrbits_le32(GXBB_GPIO_OUT(3), BIT(14));
> > +       mdelay(10);
> > +       setbits_le32(GXBB_GPIO_OUT(3), BIT(14));
> 
> Once you have a GPIO/pinctrl driver this could presumably be replaced.

Yeah, that's in my TODO list.

Thanks,
Beniamino

  parent reply	other threads:[~2016-05-08  6:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24  6:49 [U-Boot] [PATCH v5 0/4] Amlogic Meson GXBaby and ODROID-C2 support Beniamino Galvani
2016-04-24  6:49 ` [U-Boot] [PATCH v5 1/4] arm: implement generic PSCI reset call for armv8 Beniamino Galvani
2016-04-24  6:50 ` [U-Boot] [PATCH v5 2/4] net: designware: fix descriptor layout and warnings on 64-bit archs Beniamino Galvani
2016-04-25 18:01   ` Joe Hershberger
2016-04-25 20:17     ` Beniamino Galvani
2016-04-25 20:32       ` Joe Hershberger
2016-04-25 20:40         ` Marek Vasut
2016-04-25 20:43           ` Tom Rini
2016-04-24  6:50 ` [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2 Beniamino Galvani
2016-04-25 20:53   ` Tom Rini
2016-04-27 10:58     ` Beniamino Galvani
2016-05-01 18:56   ` Simon Glass
2016-05-01 18:58     ` Tom Rini
2016-05-08  6:35     ` Beniamino Galvani [this message]
2016-04-24  6:50 ` [U-Boot] [PATCH v5 4/4] arm: meson: implement calls to secure monitor Beniamino Galvani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160508063516.GA3222@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox