From mboxrd@z Thu Jan  1 00:00:00 1970
From: Beniamino Galvani <b.galvani@gmail.com>
Date: Sun, 8 May 2016 08:35:16 +0200
Subject: [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic
 Meson and ODROID-C2
In-Reply-To: <CAPnjgZ2-g2YYfBoHMfV2An3GOX2gU_fuG+mOYZAtkowrs5mq7Q@mail.gmail.com>
References: <1461480602-2932-1-git-send-email-b.galvani@gmail.com>
 <1461480602-2932-4-git-send-email-b.galvani@gmail.com>
 <CAPnjgZ2-g2YYfBoHMfV2An3GOX2gU_fuG+mOYZAtkowrs5mq7Q@mail.gmail.com>
Message-ID: <20160508063516.GA3222@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, May 01, 2016 at 12:56:21PM -0600, Simon Glass wrote:
> > +config ARCH_MESON
> > +       bool "Amlogic Meson"
> 
> Please add a help message describing what this is and what features it has.

Fixed in v7.

> > +       /* Reset PHY on GPIOZ_14 */
> > +       clrbits_le32(GXBB_GPIO_EN(3), BIT(14));
> > +       clrbits_le32(GXBB_GPIO_OUT(3), BIT(14));
> > +       mdelay(10);
> > +       setbits_le32(GXBB_GPIO_OUT(3), BIT(14));
> 
> Once you have a GPIO/pinctrl driver this could presumably be replaced.

Yeah, that's in my TODO list.

Thanks,
Beniamino