From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 8/8] board: am335x: Allow to choose serial device dynamically
Date: Tue, 17 May 2016 07:26:37 -0400 [thread overview]
Message-ID: <20160517112637.GO4404@bill-the-cat> (raw)
In-Reply-To: <573A9BE9.9020100@ti.com>
On Tue, May 17, 2016 at 09:49:53AM +0530, Lokesh Vutla wrote:
>
>
> On 5/17/2016 6:11 AM, Tom Rini wrote:
> >On Mon, May 16, 2016 at 11:47:29AM +0530, Lokesh Vutla wrote:
> >
> >>Different AM335x based platforms have different serial consoles. As serial
> >>console is Kconfig option a separate defconfig has to be created for each
> >>platform. So pass the serial device dynamically.
> >>
> >>Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >>---
> >>Changes since v1:
> >>- New patch.
> >> board/ti/am335x/board.c | 11 +++++++++++
> >> include/serial.h | 4 ++++
> >> 2 files changed, 15 insertions(+)
> >>
> >>diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
> >>index ff52314..56f4984 100644
> >>--- a/board/ti/am335x/board.c
> >>+++ b/board/ti/am335x/board.c
> >>@@ -11,6 +11,7 @@
> >> #include <common.h>
> >> #include <errno.h>
> >> #include <spl.h>
> >>+#include <serial.h>
> >> #include <asm/arch/cpu.h>
> >> #include <asm/arch/hardware.h>
> >> #include <asm/arch/omap.h>
> >>@@ -59,6 +60,16 @@ static inline int __maybe_unused read_eeprom(void)
> >> return ti_i2c_eeprom_am_get(-1, CONFIG_SYS_I2C_EEPROM_ADDR);
> >> }
> >>
> >>+#ifndef CONFIG_DM_SERIAL
> >>+struct serial_device *default_serial_console(void)
> >>+{
> >>+ if (board_is_icev2())
> >>+ return &eserial4_device;
> >>+ else
> >>+ return &eserial1_device;
> >>+}
> >>+#endif
> >>+
> >> #ifndef CONFIG_SKIP_LOWLEVEL_INIT
> >> static const struct ddr_data ddr2_data = {
> >> .datardsratio0 = MT47H128M16RT25E_RD_DQS,
> >
> >... so in the DM case we're already handling this correctly? Can't we
>
> With DM+DT we are handling it correctly which is only in U-Boot.
> This part of code is meant for only SPL(DM_* is not yet enabled in
> SPL).
... aren't we in the middle of doing this conversion 'tho?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160517/8f8a67f5/attachment.sig>
next prev parent reply other threads:[~2016-05-17 11:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 6:17 [U-Boot] [PATCH v2 0/8] ARM: AM335x: Add support for ICEv2 board Lokesh Vutla
2016-05-16 6:17 ` [U-Boot] [PATCH v2 1/8] board: AM335x-ICEv2: Add epprom support Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 2/8] board: AM335x-ICEv2: Add pinmux support Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 3/8] board: AM335x-ICEv2: Add DDR data Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot,v2,3/8] " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 4/8] ARM: AM33xx: Add support for Clock Synthesizer Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 5/8] board: AM335x-ICEv2: Add cpsw support Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot,v2,5/8] " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 6/8] config: env: Set AM335x-ICEv2 board specific env Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 7/8] ARM: dts: AM335x-ICEv2: Add minimal dts support Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-05-16 6:17 ` [U-Boot] [PATCH v2 8/8] board: am335x: Allow to choose serial device dynamically Lokesh Vutla
2016-05-17 0:41 ` Tom Rini
2016-05-17 4:19 ` Lokesh Vutla
2016-05-17 11:26 ` Tom Rini [this message]
2016-05-17 13:04 ` Lokesh Vutla
2016-05-30 18:05 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517112637.GO4404@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox