[U-Boot] [PATCH 1/2] mmc: Add Amlogic Meson driver

Kevin Hilman
2016-05-13T16:07:52Z

Carlo Caione <carlo@caione.org> writes:

> On Fri, May 13, 2016 at 3:46 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Carlo Caione <carlo@caione.org> writes:
>>
>>> From: Carlo Caione <carlo@endlessm.com>
>>>
>>> This is a port / rewrite of the Amlogic driver shipped whithin the
>>> Amlogic SDK for the Meson GXBaby (S905) SoC.
>>>
>>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>>
>> [...]
>>
>>> +static const struct udevice_id meson_mmc_match[] = {
>>> + { .compatible = "amlogic,meson-mmc" },
>>> + { /* sentinel */ }
>>
>> IIUC, this controller is different between meson8* and gxbb. If that's
>> the case, this compatible should probably be more specific.
>
> Yes, this is a point I raised also on lkml when I submitted the MMC
> driver for the Meson8b.
> Since the registers mapping is different I assume that this is the
> case. Just to be sure, given that you are the only one with a
> datasheet for the GXBB, can you confirm that?

I took a quick look and just compared the register layouts between s805
and s905 and indeed they are quite different.

Kevin