From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Mon, 30 May 2016 13:59:48 +0200
Subject: [U-Boot] [RFC PATCH 2/5] spl: dfu: fs: adding ext4/fat
 filesystem support for SPL-DFU
In-Reply-To: <1464356373-8375-3-git-send-email-ravibabu@ti.com>
References: <1464356373-8375-1-git-send-email-ravibabu@ti.com>
 <1464356373-8375-3-git-send-email-ravibabu@ti.com>
Message-ID: <20160530135948.479d7a33@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Ravi,

> Adding ext4/fat filesytem support for SPL-DFU to
> write ext4/fat files to eMMC, MMC/SD device
> 
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> ---
>  cmd/Makefile    |    9 +++++++++
>  common/Makefile |    4 +++-
>  fs/Makefile     |   12 +++++++++++-
>  3 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/cmd/Makefile b/cmd/Makefile
> index 139189e..ad89e09 100644
> --- a/cmd/Makefile
> +++ b/cmd/Makefile
> @@ -12,6 +12,15 @@ CONFIG_INC_COMMON=n
>  endif
>  endif
>  
> +ifeq ($(CONFIG_INC_COMMON),y)
> +obj-$(CONFIG_CMD_EXT4) += ext4.o
> +obj-$(CONFIG_CMD_EXT2) += ext2.o
> +obj-$(CONFIG_CMD_FAT) += fat.o
> +obj-$(CONFIG_CMD_FDC) += fdc.o
> +obj-$(CONFIG_CMD_FS_GENERIC) += fs.o
> +obj-$(CONFIG_CMD_SCSI) += scsi.o
> +endif

Could we extend code from ./common/spl/spl_fat.c
or ./common/spl/spl_ext to support write ?

> +
>  ifndef CONFIG_SPL_BUILD
>  # core command
>  obj-y += boot.o
> diff --git a/common/Makefile b/common/Makefile
> index 3576fac..99de9e1 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -24,6 +24,9 @@ obj-y += env_attr.o
>  obj-y += env_callback.o
>  obj-y += env_flags.o
>  obj-y += cli.o
> +ifdef CONFIG_CMD_USB
> +obj-$(CONFIG_USB_STORAGE) += usb_storage.o
> +endif
>  endif
>  
>  ifndef CONFIG_SPL_BUILD
> @@ -78,7 +81,6 @@ obj-$(CONFIG_PHYLIB) += miiphyutil.o
>  
>  ifdef CONFIG_CMD_USB
>  obj-y += usb.o usb_hub.o
> -obj-$(CONFIG_USB_STORAGE) += usb_storage.o
>  endif
>  
>  # others
> diff --git a/fs/Makefile b/fs/Makefile
> index 51d06fc..d4490a9 100644
> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -6,11 +6,21 @@
>  # SPDX-License-Identifier:	GPL-2.0+
>  #
>  
> +CONFIG_INC_COMMON=y
> +ifdef CONFIG_SPL_BUILD
> +ifndef CONFIG_SPL_DFU
> +CONFIG_INC_COMMON=n
> +endif
> +endif
> +
> +ifeq ($(CONFIG_INC_COMMON),y)
> +obj-y				+= fs.o
> +endif
> +
>  ifdef CONFIG_SPL_BUILD
>  obj-$(CONFIG_SPL_FAT_SUPPORT) += fat/
>  obj-$(CONFIG_SPL_EXT_SUPPORT) += ext4/
>  else
> -obj-y				+= fs.o
>  
>  obj-$(CONFIG_CMD_CBFS) += cbfs/
>  obj-$(CONFIG_CMD_CRAMFS) += cramfs/

Just side question:

How large could be the SPL code for your board (dra7x)?

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group