U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid
Date: Thu, 2 Jun 2016 15:54:12 -0400	[thread overview]
Message-ID: <20160602195412.GX7419@bill-the-cat> (raw)
In-Reply-To: <1464871467-22269-1-git-send-email-ravibabu@ti.com>

On Thu, Jun 02, 2016 at 06:14:27PM +0530, Ravi Babu wrote:
> Avoid use of hard coded mmcdev value so finduuid works
> based on current mmcdev selected.
> 
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> ---
>  include/configs/ti_armv7_common.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> index 7db0881..bbff06b 100644
> --- a/include/configs/ti_armv7_common.h
> +++ b/include/configs/ti_armv7_common.h
> @@ -59,7 +59,7 @@
>  #define DEFAULT_MMC_TI_ARGS \
>  	"mmcdev=0\0" \
>  	"mmcrootfstype=ext4 rootwait\0" \
> -	"finduuid=part uuid mmc 0:2 uuid\0" \
> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>  		"${optargs} " \
>  		"root=PARTUUID=${uuid} rw " \

Good, but incomplete find.  am33xx doesn't, but other TI families do,
"common"-out the bootpart variable and this is what should be used here,
after making sure everyone that uses this has a bootpart set.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160602/85d7c49b/attachment.sig>

  parent reply	other threads:[~2016-06-02 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 12:44 [U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid Ravi Babu
2016-06-02 14:07 ` Lokesh Vutla
2016-06-02 19:54 ` Tom Rini [this message]
2016-06-03  7:51   ` B, Ravi
2016-06-03  8:05   ` B, Ravi
2016-06-03 13:50     ` Tom Rini
2016-06-03 14:18       ` B, Ravi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602195412.GX7419@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox