[U-Boot] [PATCH] arm: lib: fix push/pop-section directives

Marek Vasut
2016-06-04T00:43:06Z

On 06/03/2016 09:14 PM, Tom Rini wrote:
> On Fri, Jun 03, 2016 at 01:05:11PM -0600, Stephen Warren wrote:
>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> With the existing code, function symbols are defined in .text, and the
>> body is defined in .text.xxx. This causes (at least some version of) the
>> linker not to emit the function body into the final binary, since it's
>> part of a different section to the symbols being referenced. This of
>> course causes a wide variety of failures.
>>
>> This change moves the push/pop-section directives before the function
>> symbols, and after any relate ENDPROC macro invocations, so that symbols
>> and bodies are all in the "pushed" sections, and thus the function bodies
>> are emitted into the binary.
>>
>> This solves (at least) the boot problems currently seen on Tegra systems
>> that use SPL (i.e. all ARMv7 Tegras).
>>
>> Fixes: 13b0a91a6d48 ("arm: lib: Split asm symbols into different .text subsections")
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Tom Warren <twarren@nvidia.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Applied to u-boot/master, thanks!
>
Thanks!

--
Best regards,
Marek Vasut