public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Make FIT support really optional
Date: Sat, 4 Jun 2016 09:06:58 -0400	[thread overview]
Message-ID: <20160604130658.GC11619@bill-the-cat> (raw)
In-Reply-To: <1464981386-26342-1-git-send-email-casantos@datacom.ind.br>

On Fri, Jun 03, 2016 at 04:16:26PM -0300, Carlos Santos wrote:

> Due to some mistakes in the source code, it was not possible to really
> turn FIT support off. This commit fixes the problem by means of the
> following changes:
> 
> - Enclose "bootm_host_load_image" and "bootm_host_load_images" between
>   checks for CONFIG_FIT_SIGNATURE, in common/bootm.c.
> 
> - Enclose the declaration of "bootm_host_load_images" between checks for
>   CONFIG_FIT_SIGNATURE, in common/bootm.h.
> 
> - Condition the compilation and linking of fit_common.o fit_image.o
>   image-host.o common/image-fit.o to CONFIG_FIT=y, in tools/Makefile.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
> Changes v1 -> v2
>  Rebased to the top of master branch.
> 
>  common/bootm.c  | 2 ++
>  include/bootm.h | 2 ++
>  tools/Makefile  | 6 ++----
>  3 files changed, 6 insertions(+), 4 deletions(-)

So, why?  I don't like the idea of making FIT support in mkimage
conditional.  This makes the life of distribution people harder, not
easier.  The functions in common/bootm.c should be being discarded in
U-Boot itself when we don't have CONFIG_FIT_SIGNATURE.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160604/8a1937d2/attachment.sig>

  parent reply	other threads:[~2016-06-04 13:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 15:06 [U-Boot] [PATCH 4/4] Make FIT support really optional Carlos Santos
2016-06-03 19:16 ` [U-Boot] [PATCH v2] " Carlos Santos
2016-06-04 12:09   ` Otavio Salvador
2016-06-04 13:06   ` Tom Rini [this message]
2016-06-04 17:39     ` Carlos Santos
2016-06-06 11:42       ` Carlos Santos
2016-06-07 20:37       ` Thomas Petazzoni
2016-06-08  0:18         ` Carlos Santos
2016-06-08  5:47           ` Thomas Petazzoni
2016-06-08 12:17             ` Tom Rini
2016-06-10  1:09               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160604130658.GC11619@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox