From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Mon, 6 Jun 2016 20:31:33 +0200 Subject: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver In-Reply-To: <1465235808.22191.86.camel@buserror.net> References: <1465226478-22252-1-git-send-email-boris.brezillon@free-electrons.com> <1465226478-22252-4-git-send-email-boris.brezillon@free-electrons.com> <31991e89-53e0-0d9c-c643-241c6f8e8d51@redhat.com> <20160606182223.1636b0df@bbrezillon> <1465235808.22191.86.camel@buserror.net> Message-ID: <20160606203133.07e61264@bbrezillon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 06 Jun 2016 12:56:48 -0500 Scott Wood wrote: > On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > > On Mon, 6 Jun 2016 17:36:10 +0200 > > Hans de Goede wrote: > > > > > > +#ifndef CONFIG_SPL_BUILD > > > > +void sunxi_nand_init(void); > > > > +#endif > > > > + > > > > > > Can we have this in a header somewhere please, and without > > > the #ifdef around it, that is not necessary for prototypes. > > > > Hehe, I was expecting this one :-). Do you know where I should put this > > prototype definition? A board.h file in board/sunxi/? > > It's defined in drivers/mtd/nand and called from board/sunxi so the prototype > needs to go somewhere under include/. It can go in include/configs/sunxi > -common.h with #ifndef __ASSEMBLY__ around it -- or as long as it's limited to > one init func per driver, maybe we could just put it in include/nand.h. Hm, none of these solutions seem ideal. Maybe we could define a generic void nand_controller_init(void) prototype so that we don't need to add new xxx_nand_init() functions for platforms needing this 2 steps initialization (platform specific pinmux + clocks config before NAND controller initialization). Otherwise, I think I'll go for the 2nd solution (defining sunxi_nand_init() in include/nand.h). Let me know what you prefer. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com