* [U-Boot] [PATCH 0/2] Prepare U-Boot for more Amlogic boards @ 2016-06-09 14:45 Carlo Caione 2016-06-09 14:45 ` [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file Carlo Caione 2016-06-09 14:45 ` [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards Carlo Caione 0 siblings, 2 replies; 8+ messages in thread From: Carlo Caione @ 2016-06-09 14:45 UTC (permalink / raw) To: u-boot From: Carlo Caione <carlo@endlessm.com> Refactor the Odroid-C2 support code to prepare U-Boot for more Amlogic board submissions. The goal is to reduce the redundancy of the configuration files and unify all the board support files onto a single amlogic directory. Carlo Caione (2): configs: gxbb: Introduce a common config header file board: amlogic: Rename folder for Amlogic boards arch/arm/mach-meson/Kconfig | 2 +- board/amlogic/odroid-c2/Kconfig | 12 ++++++ board/amlogic/odroid-c2/MAINTAINERS | 6 +++ board/amlogic/odroid-c2/Makefile | 7 ++++ board/amlogic/odroid-c2/README | 60 ++++++++++++++++++++++++++++++ board/amlogic/odroid-c2/odroid-c2.c | 67 ++++++++++++++++++++++++++++++++++ board/hardkernel/odroid-c2/Kconfig | 12 ------ board/hardkernel/odroid-c2/MAINTAINERS | 6 --- board/hardkernel/odroid-c2/Makefile | 7 ---- board/hardkernel/odroid-c2/README | 60 ------------------------------ board/hardkernel/odroid-c2/odroid-c2.c | 67 ---------------------------------- include/configs/meson-gxbb-common.h | 45 +++++++++++++++++++++++ include/configs/odroid-c2.h | 34 +---------------- 13 files changed, 199 insertions(+), 186 deletions(-) create mode 100644 board/amlogic/odroid-c2/Kconfig create mode 100644 board/amlogic/odroid-c2/MAINTAINERS create mode 100644 board/amlogic/odroid-c2/Makefile create mode 100644 board/amlogic/odroid-c2/README create mode 100644 board/amlogic/odroid-c2/odroid-c2.c delete mode 100644 board/hardkernel/odroid-c2/Kconfig delete mode 100644 board/hardkernel/odroid-c2/MAINTAINERS delete mode 100644 board/hardkernel/odroid-c2/Makefile delete mode 100644 board/hardkernel/odroid-c2/README delete mode 100644 board/hardkernel/odroid-c2/odroid-c2.c create mode 100644 include/configs/meson-gxbb-common.h -- 2.7.4 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file 2016-06-09 14:45 [U-Boot] [PATCH 0/2] Prepare U-Boot for more Amlogic boards Carlo Caione @ 2016-06-09 14:45 ` Carlo Caione 2016-06-10 0:36 ` Simon Glass 2016-06-09 14:45 ` [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards Carlo Caione 1 sibling, 1 reply; 8+ messages in thread From: Carlo Caione @ 2016-06-09 14:45 UTC (permalink / raw) To: u-boot From: Carlo Caione <carlo@endlessm.com> Introduce a meson-gxbb-common.h header file and derive the configuration for Hardkernel Odroid-C2 board from that. Signed-off-by: Carlo Caione <carlo@endlessm.com> --- include/configs/meson-gxbb-common.h | 45 +++++++++++++++++++++++++++++++++++++ include/configs/odroid-c2.h | 34 +--------------------------- 2 files changed, 46 insertions(+), 33 deletions(-) create mode 100644 include/configs/meson-gxbb-common.h diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h new file mode 100644 index 0000000..d1c0050 --- /dev/null +++ b/include/configs/meson-gxbb-common.h @@ -0,0 +1,45 @@ +/* + * Configuration for Amlogic Meson GXBB SoCs + * (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#ifndef __MESON_GXBB_COMMON_CONFIG_H +#define __MESON_GXBB_COMMON_CONFIG_H + +#define CONFIG_CPU_ARMV8 +#define CONFIG_REMAKE_ELF +#define CONFIG_SYS_CACHELINE_SIZE 64 +#define CONFIG_SYS_NO_FLASH +#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_ENV_IS_NOWHERE 1 +#define CONFIG_ENV_SIZE 0x2000 +#define CONFIG_SYS_MAXARGS 32 +#define CONFIG_SYS_MALLOC_LEN (32 << 20) +#define CONFIG_SYS_CBSIZE 1024 +#define CONFIG_MISC_INIT_R + +#define CONFIG_SYS_SDRAM_BASE 0 +#define CONFIG_SYS_TEXT_BASE 0x01000000 +#define CONFIG_SYS_INIT_SP_ADDR 0x20000000 +#define CONFIG_SYS_LOAD_ADDR CONFIG_SYS_TEXT_BASE + +/* Generic Interrupt Controller Definitions */ +#define GICD_BASE 0xc4301000 +#define GICC_BASE 0xc4302000 + +#define CONFIG_CMD_ENV + +/* Monitor Command Prompt */ +/* Console I/O Buffer Size */ +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_HUSH_PARSER +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE +#define CONFIG_SYS_LONGHELP +#define CONFIG_CMDLINE_EDITING + +#include <config_distro_defaults.h> + +#endif /* __MESON_GXBB_COMMON_CONFIG_H */ diff --git a/include/configs/odroid-c2.h b/include/configs/odroid-c2.h index 37a5671..bf5df9c 100644 --- a/include/configs/odroid-c2.h +++ b/include/configs/odroid-c2.h @@ -8,44 +8,12 @@ #ifndef __CONFIG_H #define __CONFIG_H -#define CONFIG_CPU_ARMV8 -#define CONFIG_REMAKE_ELF -#define CONFIG_SYS_CACHELINE_SIZE 64 -#define CONFIG_SYS_NO_FLASH -#define CONFIG_NR_DRAM_BANKS 1 -#define CONFIG_ENV_IS_NOWHERE 1 -#define CONFIG_ENV_SIZE 0x2000 -#define CONFIG_SYS_MAXARGS 32 -#define CONFIG_SYS_MALLOC_LEN (32 << 20) -#define CONFIG_SYS_CBSIZE 1024 -#define CONFIG_MISC_INIT_R - -#define CONFIG_SYS_SDRAM_BASE 0 -#define CONFIG_SYS_TEXT_BASE 0x01000000 -#define CONFIG_SYS_INIT_SP_ADDR 0x20000000 -#define CONFIG_SYS_LOAD_ADDR CONFIG_SYS_TEXT_BASE - -/* Generic Interrupt Controller Definitions */ -#define GICD_BASE 0xc4301000 -#define GICC_BASE 0xc4302000 - #define CONFIG_IDENT_STRING " odroid-c2" /* Serial setup */ #define CONFIG_CONS_INDEX 0 #define CONFIG_BAUDRATE 115200 -#define CONFIG_CMD_ENV - -/* Monitor Command Prompt */ -/* Console I/O Buffer Size */ -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ - sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_HUSH_PARSER -#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE -#define CONFIG_SYS_LONGHELP -#define CONFIG_CMDLINE_EDITING - -#include <config_distro_defaults.h> +#include <configs/meson-gxbb-common.h> #endif /* __CONFIG_H */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file 2016-06-09 14:45 ` [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file Carlo Caione @ 2016-06-10 0:36 ` Simon Glass 0 siblings, 0 replies; 8+ messages in thread From: Simon Glass @ 2016-06-10 0:36 UTC (permalink / raw) To: u-boot On 9 June 2016 at 08:45, Carlo Caione <carlo@caione.org> wrote: > From: Carlo Caione <carlo@endlessm.com> > > Introduce a meson-gxbb-common.h header file and derive the > configuration for Hardkernel Odroid-C2 board from that. > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > --- > include/configs/meson-gxbb-common.h | 45 +++++++++++++++++++++++++++++++++++++ > include/configs/odroid-c2.h | 34 +--------------------------- > 2 files changed, 46 insertions(+), 33 deletions(-) > create mode 100644 include/configs/meson-gxbb-common.h Reviewed-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards 2016-06-09 14:45 [U-Boot] [PATCH 0/2] Prepare U-Boot for more Amlogic boards Carlo Caione 2016-06-09 14:45 ` [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file Carlo Caione @ 2016-06-09 14:45 ` Carlo Caione 2016-06-10 0:36 ` Simon Glass 1 sibling, 1 reply; 8+ messages in thread From: Carlo Caione @ 2016-06-09 14:45 UTC (permalink / raw) To: u-boot From: Carlo Caione <carlo@endlessm.com> s/hardkernel/amlogic/ to have a single place for all the amlogic-based boards. Signed-off-by: Carlo Caione <carlo@endlessm.com> --- arch/arm/mach-meson/Kconfig | 2 +- board/amlogic/odroid-c2/Kconfig | 12 ++++++ board/amlogic/odroid-c2/MAINTAINERS | 6 +++ board/amlogic/odroid-c2/Makefile | 7 ++++ board/amlogic/odroid-c2/README | 60 ++++++++++++++++++++++++++++++ board/amlogic/odroid-c2/odroid-c2.c | 67 ++++++++++++++++++++++++++++++++++ board/hardkernel/odroid-c2/Kconfig | 12 ------ board/hardkernel/odroid-c2/MAINTAINERS | 6 --- board/hardkernel/odroid-c2/Makefile | 7 ---- board/hardkernel/odroid-c2/README | 60 ------------------------------ board/hardkernel/odroid-c2/odroid-c2.c | 67 ---------------------------------- 11 files changed, 153 insertions(+), 153 deletions(-) create mode 100644 board/amlogic/odroid-c2/Kconfig create mode 100644 board/amlogic/odroid-c2/MAINTAINERS create mode 100644 board/amlogic/odroid-c2/Makefile create mode 100644 board/amlogic/odroid-c2/README create mode 100644 board/amlogic/odroid-c2/odroid-c2.c delete mode 100644 board/hardkernel/odroid-c2/Kconfig delete mode 100644 board/hardkernel/odroid-c2/MAINTAINERS delete mode 100644 board/hardkernel/odroid-c2/Makefile delete mode 100644 board/hardkernel/odroid-c2/README delete mode 100644 board/hardkernel/odroid-c2/odroid-c2.c diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig index 77d3cfe..af3be59 100644 --- a/arch/arm/mach-meson/Kconfig +++ b/arch/arm/mach-meson/Kconfig @@ -26,6 +26,6 @@ config SYS_SOC config SYS_MALLOC_F_LEN default 0x1000 -source "board/hardkernel/odroid-c2/Kconfig" +source "board/amlogic/odroid-c2/Kconfig" endif diff --git a/board/amlogic/odroid-c2/Kconfig b/board/amlogic/odroid-c2/Kconfig new file mode 100644 index 0000000..2b16889 --- /dev/null +++ b/board/amlogic/odroid-c2/Kconfig @@ -0,0 +1,12 @@ +if TARGET_ODROID_C2 + +config SYS_BOARD + default "odroid-c2" + +config SYS_VENDOR + default "amlogic" + +config SYS_CONFIG_NAME + default "odroid-c2" + +endif diff --git a/board/amlogic/odroid-c2/MAINTAINERS b/board/amlogic/odroid-c2/MAINTAINERS new file mode 100644 index 0000000..699850f --- /dev/null +++ b/board/amlogic/odroid-c2/MAINTAINERS @@ -0,0 +1,6 @@ +ODROID-C2 +M: Beniamino Galvani <b.galvani@gmail.com> +S: Maintained +F: board/amlogic/odroid-c2/ +F: include/configs/odroid-c2.h +F: configs/odroid-c2_defconfig diff --git a/board/amlogic/odroid-c2/Makefile b/board/amlogic/odroid-c2/Makefile new file mode 100644 index 0000000..571044b --- /dev/null +++ b/board/amlogic/odroid-c2/Makefile @@ -0,0 +1,7 @@ +# +# (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y := odroid-c2.o diff --git a/board/amlogic/odroid-c2/README b/board/amlogic/odroid-c2/README new file mode 100644 index 0000000..d6d266a --- /dev/null +++ b/board/amlogic/odroid-c2/README @@ -0,0 +1,60 @@ +U-Boot for ODROID-C2 +==================== + +ODROID-C2 is a single board computer manufactured by Hardkernel +Co. Ltd with the following specifications: + + - Amlogic S905 ARM Cortex-A53 quad-core SoC @ 2GHz + - ARM Mali 450 GPU + - 2GB DDR3 SDRAM + - Gigabit Ethernet + - HDMI 2.0 4K/60Hz display + - 40-pin GPIO header + - 4 x USB 2.0 Host, 1 x USB OTG + - eMMC, microSD + - Infrared receiver + +Schematics are available on the manufacturer website. + +Currently the u-boot port supports the following devices: + - serial + - Ethernet + +u-boot compilation +================== + + > export ARCH=arm + > export CROSS_COMPILE=aarch64-none-elf- + > make odroid-c2_defconfig + > make + +Image creation +============== + +Amlogic doesn't provide sources for the firmware and for tools needed +to create the bootloader image, so it is necessary to obtain them from +the git tree published by the board vendor: + + > DIR=odroid-c2 + > git clone --depth 1 \ + https://github.com/hardkernel/u-boot.git -b odroidc2-v2015.01 \ + $DIR + > $DIR/fip/fip_create --bl30 $DIR/fip/gxb/bl30.bin \ + --bl301 $DIR/fip/gxb/bl301.bin \ + --bl31 $DIR/fip/gxb/bl31.bin \ + --bl33 u-boot.bin \ + $DIR/fip.bin + > $DIR/fip/fip_create --dump $DIR/fip.bin + > cat $DIR/fip/gxb/bl2.package $DIR/fip.bin > $DIR/boot_new.bin + > $DIR/fip/gxb/aml_encrypt_gxb --bootsig \ + --input $DIR/boot_new.bin \ + --output $DIR/u-boot.img + > dd if=$DIR/u-boot.img of=$DIR/u-boot.gxbb bs=512 skip=96 + +and then write the image to SD with: + + > DEV=/dev/your_sd_device + > BL1=$DIR/sd_fuse/bl1.bin.hardkernel + > dd if=$BL1 of=$DEV conv=fsync bs=1 count=442 + > dd if=$BL1 of=$DEV conv=fsync bs=512 skip=1 seek=1 + > dd if=$DIR/u-boot.gxbb of=$DEV conv=fsync bs=512 seek=97 diff --git a/board/amlogic/odroid-c2/odroid-c2.c b/board/amlogic/odroid-c2/odroid-c2.c new file mode 100644 index 0000000..bd72100 --- /dev/null +++ b/board/amlogic/odroid-c2/odroid-c2.c @@ -0,0 +1,67 @@ +/* + * (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include <common.h> +#include <asm/io.h> +#include <asm/arch/gxbb.h> +#include <asm/arch/sm.h> +#include <dm/platdata.h> +#include <phy.h> + +#define EFUSE_SN_OFFSET 20 +#define EFUSE_SN_SIZE 16 +#define EFUSE_MAC_OFFSET 52 +#define EFUSE_MAC_SIZE 6 + +int board_init(void) +{ + return 0; +} + +static const struct eth_pdata gxbb_eth_pdata = { + .iobase = GXBB_ETH_BASE, + .phy_interface = PHY_INTERFACE_MODE_RGMII, +}; + +U_BOOT_DEVICE(meson_eth) = { + .name = "eth_designware", + .platdata = &gxbb_eth_pdata, +}; + +int misc_init_r(void) +{ + u8 mac_addr[EFUSE_MAC_SIZE]; + ssize_t len; + + /* Select Ethernet function */ + setbits_le32(GXBB_PINMUX(6), 0x3fff); + + /* Set RGMII mode */ + setbits_le32(GXBB_ETH_REG_0, GXBB_ETH_REG_0_PHY_INTF | + GXBB_ETH_REG_0_TX_PHASE(1) | + GXBB_ETH_REG_0_TX_RATIO(4) | + GXBB_ETH_REG_0_PHY_CLK_EN | + GXBB_ETH_REG_0_CLK_EN); + + /* Enable power and clock gate */ + setbits_le32(GXBB_GCLK_MPEG_1, GXBB_GCLK_MPEG_1_ETH); + clrbits_le32(GXBB_MEM_PD_REG_0, GXBB_MEM_PD_REG_0_ETH_MASK); + + /* Reset PHY on GPIOZ_14 */ + clrbits_le32(GXBB_GPIO_EN(3), BIT(14)); + clrbits_le32(GXBB_GPIO_OUT(3), BIT(14)); + mdelay(10); + setbits_le32(GXBB_GPIO_OUT(3), BIT(14)); + + if (!eth_getenv_enetaddr("ethaddr", mac_addr)) { + len = meson_sm_read_efuse(EFUSE_MAC_OFFSET, + mac_addr, EFUSE_MAC_SIZE); + if (len == EFUSE_MAC_SIZE && is_valid_ethaddr(mac_addr)) + eth_setenv_enetaddr("ethaddr", mac_addr); + } + + return 0; +} diff --git a/board/hardkernel/odroid-c2/Kconfig b/board/hardkernel/odroid-c2/Kconfig deleted file mode 100644 index 687d9c6..0000000 --- a/board/hardkernel/odroid-c2/Kconfig +++ /dev/null @@ -1,12 +0,0 @@ -if TARGET_ODROID_C2 - -config SYS_BOARD - default "odroid-c2" - -config SYS_VENDOR - default "hardkernel" - -config SYS_CONFIG_NAME - default "odroid-c2" - -endif diff --git a/board/hardkernel/odroid-c2/MAINTAINERS b/board/hardkernel/odroid-c2/MAINTAINERS deleted file mode 100644 index 23ae1e7..0000000 --- a/board/hardkernel/odroid-c2/MAINTAINERS +++ /dev/null @@ -1,6 +0,0 @@ -ODROID-C2 -M: Beniamino Galvani <b.galvani@gmail.com> -S: Maintained -F: board/hardkernel/odroid-c2/ -F: include/configs/odroid-c2.h -F: configs/odroid-c2_defconfig diff --git a/board/hardkernel/odroid-c2/Makefile b/board/hardkernel/odroid-c2/Makefile deleted file mode 100644 index 571044b..0000000 --- a/board/hardkernel/odroid-c2/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -# -# (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> -# -# SPDX-License-Identifier: GPL-2.0+ -# - -obj-y := odroid-c2.o diff --git a/board/hardkernel/odroid-c2/README b/board/hardkernel/odroid-c2/README deleted file mode 100644 index d6d266a..0000000 --- a/board/hardkernel/odroid-c2/README +++ /dev/null @@ -1,60 +0,0 @@ -U-Boot for ODROID-C2 -==================== - -ODROID-C2 is a single board computer manufactured by Hardkernel -Co. Ltd with the following specifications: - - - Amlogic S905 ARM Cortex-A53 quad-core SoC @ 2GHz - - ARM Mali 450 GPU - - 2GB DDR3 SDRAM - - Gigabit Ethernet - - HDMI 2.0 4K/60Hz display - - 40-pin GPIO header - - 4 x USB 2.0 Host, 1 x USB OTG - - eMMC, microSD - - Infrared receiver - -Schematics are available on the manufacturer website. - -Currently the u-boot port supports the following devices: - - serial - - Ethernet - -u-boot compilation -================== - - > export ARCH=arm - > export CROSS_COMPILE=aarch64-none-elf- - > make odroid-c2_defconfig - > make - -Image creation -============== - -Amlogic doesn't provide sources for the firmware and for tools needed -to create the bootloader image, so it is necessary to obtain them from -the git tree published by the board vendor: - - > DIR=odroid-c2 - > git clone --depth 1 \ - https://github.com/hardkernel/u-boot.git -b odroidc2-v2015.01 \ - $DIR - > $DIR/fip/fip_create --bl30 $DIR/fip/gxb/bl30.bin \ - --bl301 $DIR/fip/gxb/bl301.bin \ - --bl31 $DIR/fip/gxb/bl31.bin \ - --bl33 u-boot.bin \ - $DIR/fip.bin - > $DIR/fip/fip_create --dump $DIR/fip.bin - > cat $DIR/fip/gxb/bl2.package $DIR/fip.bin > $DIR/boot_new.bin - > $DIR/fip/gxb/aml_encrypt_gxb --bootsig \ - --input $DIR/boot_new.bin \ - --output $DIR/u-boot.img - > dd if=$DIR/u-boot.img of=$DIR/u-boot.gxbb bs=512 skip=96 - -and then write the image to SD with: - - > DEV=/dev/your_sd_device - > BL1=$DIR/sd_fuse/bl1.bin.hardkernel - > dd if=$BL1 of=$DEV conv=fsync bs=1 count=442 - > dd if=$BL1 of=$DEV conv=fsync bs=512 skip=1 seek=1 - > dd if=$DIR/u-boot.gxbb of=$DEV conv=fsync bs=512 seek=97 diff --git a/board/hardkernel/odroid-c2/odroid-c2.c b/board/hardkernel/odroid-c2/odroid-c2.c deleted file mode 100644 index bd72100..0000000 --- a/board/hardkernel/odroid-c2/odroid-c2.c +++ /dev/null @@ -1,67 +0,0 @@ -/* - * (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> - * - * SPDX-License-Identifier: GPL-2.0+ - */ - -#include <common.h> -#include <asm/io.h> -#include <asm/arch/gxbb.h> -#include <asm/arch/sm.h> -#include <dm/platdata.h> -#include <phy.h> - -#define EFUSE_SN_OFFSET 20 -#define EFUSE_SN_SIZE 16 -#define EFUSE_MAC_OFFSET 52 -#define EFUSE_MAC_SIZE 6 - -int board_init(void) -{ - return 0; -} - -static const struct eth_pdata gxbb_eth_pdata = { - .iobase = GXBB_ETH_BASE, - .phy_interface = PHY_INTERFACE_MODE_RGMII, -}; - -U_BOOT_DEVICE(meson_eth) = { - .name = "eth_designware", - .platdata = &gxbb_eth_pdata, -}; - -int misc_init_r(void) -{ - u8 mac_addr[EFUSE_MAC_SIZE]; - ssize_t len; - - /* Select Ethernet function */ - setbits_le32(GXBB_PINMUX(6), 0x3fff); - - /* Set RGMII mode */ - setbits_le32(GXBB_ETH_REG_0, GXBB_ETH_REG_0_PHY_INTF | - GXBB_ETH_REG_0_TX_PHASE(1) | - GXBB_ETH_REG_0_TX_RATIO(4) | - GXBB_ETH_REG_0_PHY_CLK_EN | - GXBB_ETH_REG_0_CLK_EN); - - /* Enable power and clock gate */ - setbits_le32(GXBB_GCLK_MPEG_1, GXBB_GCLK_MPEG_1_ETH); - clrbits_le32(GXBB_MEM_PD_REG_0, GXBB_MEM_PD_REG_0_ETH_MASK); - - /* Reset PHY on GPIOZ_14 */ - clrbits_le32(GXBB_GPIO_EN(3), BIT(14)); - clrbits_le32(GXBB_GPIO_OUT(3), BIT(14)); - mdelay(10); - setbits_le32(GXBB_GPIO_OUT(3), BIT(14)); - - if (!eth_getenv_enetaddr("ethaddr", mac_addr)) { - len = meson_sm_read_efuse(EFUSE_MAC_OFFSET, - mac_addr, EFUSE_MAC_SIZE); - if (len == EFUSE_MAC_SIZE && is_valid_ethaddr(mac_addr)) - eth_setenv_enetaddr("ethaddr", mac_addr); - } - - return 0; -} -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards 2016-06-09 14:45 ` [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards Carlo Caione @ 2016-06-10 0:36 ` Simon Glass 2016-06-10 8:03 ` Ben Dooks 0 siblings, 1 reply; 8+ messages in thread From: Simon Glass @ 2016-06-10 0:36 UTC (permalink / raw) To: u-boot On 9 June 2016 at 08:45, Carlo Caione <carlo@caione.org> wrote: > From: Carlo Caione <carlo@endlessm.com> > > s/hardkernel/amlogic/ to have a single place for all the amlogic-based > boards. > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > --- > arch/arm/mach-meson/Kconfig | 2 +- > board/amlogic/odroid-c2/Kconfig | 12 ++++++ > board/amlogic/odroid-c2/MAINTAINERS | 6 +++ > board/amlogic/odroid-c2/Makefile | 7 ++++ > board/amlogic/odroid-c2/README | 60 ++++++++++++++++++++++++++++++ > board/amlogic/odroid-c2/odroid-c2.c | 67 ++++++++++++++++++++++++++++++++++ > board/hardkernel/odroid-c2/Kconfig | 12 ------ > board/hardkernel/odroid-c2/MAINTAINERS | 6 --- > board/hardkernel/odroid-c2/Makefile | 7 ---- > board/hardkernel/odroid-c2/README | 60 ------------------------------ > board/hardkernel/odroid-c2/odroid-c2.c | 67 ---------------------------------- > 11 files changed, 153 insertions(+), 153 deletions(-) > create mode 100644 board/amlogic/odroid-c2/Kconfig > create mode 100644 board/amlogic/odroid-c2/MAINTAINERS > create mode 100644 board/amlogic/odroid-c2/Makefile > create mode 100644 board/amlogic/odroid-c2/README > create mode 100644 board/amlogic/odroid-c2/odroid-c2.c > delete mode 100644 board/hardkernel/odroid-c2/Kconfig > delete mode 100644 board/hardkernel/odroid-c2/MAINTAINERS > delete mode 100644 board/hardkernel/odroid-c2/Makefile > delete mode 100644 board/hardkernel/odroid-c2/README > delete mode 100644 board/hardkernel/odroid-c2/odroid-c2.c Reviewed-by: Simon Glass <sjg@chromium.org> Although I'm surprised this did not come through as a rename in your patch. - Simon ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards 2016-06-10 0:36 ` Simon Glass @ 2016-06-10 8:03 ` Ben Dooks 2016-06-10 8:19 ` Carlo Caione 0 siblings, 1 reply; 8+ messages in thread From: Ben Dooks @ 2016-06-10 8:03 UTC (permalink / raw) To: u-boot do you have git rename-detection enabled? On 10 June 2016 at 01:36, Simon Glass <sjg@chromium.org> wrote: > On 9 June 2016 at 08:45, Carlo Caione <carlo@caione.org> wrote: > > From: Carlo Caione <carlo@endlessm.com> > > > > s/hardkernel/amlogic/ to have a single place for all the amlogic-based > > boards. > > > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > > --- > > arch/arm/mach-meson/Kconfig | 2 +- > > board/amlogic/odroid-c2/Kconfig | 12 ++++++ > > board/amlogic/odroid-c2/MAINTAINERS | 6 +++ > > board/amlogic/odroid-c2/Makefile | 7 ++++ > > board/amlogic/odroid-c2/README | 60 > ++++++++++++++++++++++++++++++ > > board/amlogic/odroid-c2/odroid-c2.c | 67 > ++++++++++++++++++++++++++++++++++ > > board/hardkernel/odroid-c2/Kconfig | 12 ------ > > board/hardkernel/odroid-c2/MAINTAINERS | 6 --- > > board/hardkernel/odroid-c2/Makefile | 7 ---- > > board/hardkernel/odroid-c2/README | 60 > ------------------------------ > > board/hardkernel/odroid-c2/odroid-c2.c | 67 > ---------------------------------- > > 11 files changed, 153 insertions(+), 153 deletions(-) > > create mode 100644 board/amlogic/odroid-c2/Kconfig > > create mode 100644 board/amlogic/odroid-c2/MAINTAINERS > > create mode 100644 board/amlogic/odroid-c2/Makefile > > create mode 100644 board/amlogic/odroid-c2/README > > create mode 100644 board/amlogic/odroid-c2/odroid-c2.c > > delete mode 100644 board/hardkernel/odroid-c2/Kconfig > > delete mode 100644 board/hardkernel/odroid-c2/MAINTAINERS > > delete mode 100644 board/hardkernel/odroid-c2/Makefile > > delete mode 100644 board/hardkernel/odroid-c2/README > > delete mode 100644 board/hardkernel/odroid-c2/odroid-c2.c > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Although I'm surprised this did not come through as a rename in your patch. > > - Simon > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic > -- Ben Dooks, http://www.fluff.org/ben/ bjdooks at googlemail.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards 2016-06-10 8:03 ` Ben Dooks @ 2016-06-10 8:19 ` Carlo Caione 2016-06-10 16:44 ` Simon Glass 0 siblings, 1 reply; 8+ messages in thread From: Carlo Caione @ 2016-06-10 8:19 UTC (permalink / raw) To: u-boot On 10/06/16 09:03, Ben Dooks wrote: > do you have git rename-detection enabled? I simply forgot to pass '-M' to git-format-patch. I can submit a v2 if requested. Cheers, -- Carlo Caione ^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards 2016-06-10 8:19 ` Carlo Caione @ 2016-06-10 16:44 ` Simon Glass 0 siblings, 0 replies; 8+ messages in thread From: Simon Glass @ 2016-06-10 16:44 UTC (permalink / raw) To: u-boot Hi Carlo, On 10 June 2016 at 02:19, Carlo Caione <carlo@caione.org> wrote: > On 10/06/16 09:03, Ben Dooks wrote: >> do you have git rename-detection enabled? > > I simply forgot to pass '-M' to git-format-patch. I can submit a v2 if > requested. Yes please. Also you can use patman which does this for you. If your patches are in a branch with the correct upstream: patman -nt will generate patches and patman -t will send them (you need -t because amlogic is unlikely to be a valid alias) Regards, Simon ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-10 16:44 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-06-09 14:45 [U-Boot] [PATCH 0/2] Prepare U-Boot for more Amlogic boards Carlo Caione 2016-06-09 14:45 ` [U-Boot] [PATCH 1/2] configs: gxbb: Introduce a common config header file Carlo Caione 2016-06-10 0:36 ` Simon Glass 2016-06-09 14:45 ` [U-Boot] [PATCH 2/2] board: amlogic: Rename folder for Amlogic boards Carlo Caione 2016-06-10 0:36 ` Simon Glass 2016-06-10 8:03 ` Ben Dooks 2016-06-10 8:19 ` Carlo Caione 2016-06-10 16:44 ` Simon Glass
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox